GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: prepare custom rules for ESLint v9 by targos · Pull Request #52889 · nodejs/node

Conversation

@targos

@targos targos commented May 8, 2024

Copy link
Copy Markdown
Member

Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
tools: prepare custom rules for ESLint v9
46381af 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 8, 2024
@targos

targos commented May 8, 2024

Copy link
Copy Markdown
Member Author

Easier to review with https://github.com/nodejs/node/pull/52889/files?diff=unified&w=1
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 8, 2024
@github-actions

github-actions Bot commented May 8, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
MoLow and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
fixup
db1731a
@targos targos mentioned this pull request May 8, 2024
tools: migrate to ESLint flat config and update ESLint to v9.3.0 #52780
Merged
@nodejs-github-bot

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59031/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes May 8, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59035/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes May 8, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59039/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes May 8, 2024
View reviewed changes
@MoLow MoLow added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 9, 2024
@targos

targos commented May 9, 2024

Copy link
Copy Markdown
Member Author

/cc @aduh95
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes May 9, 2024
View reviewed changes
anonrig
anonrig approved these changes May 9, 2024
View reviewed changes
@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 3c1069b into nodejs:main May 9, 2024
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in 3c1069b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the eslint-rules-v9 branch May 9, 2024 16:59
targos added a commit that referenced this pull request May 11, 2024
@targos
tools: prepare custom rules for ESLint v9
646a094 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: #52889
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
tools: prepare custom rules for ESLint v9
5700600 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: #52889
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
tools: prepare custom rules for ESLint v9
5e8b062 
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0
PR-URL: nodejs#52889
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@targos @nodejs-github-bot @lpinca @anonrig @MoLow @aduh95 @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.