GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: exclude commits with baking-for-lts by marco-ippolito · Pull Request #52896 · nodejs/node

Conversation

marco-ippolito commented May 8, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add baking-for-lts to the exclude label

cc @nodejs/releasers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented May 8, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

May 8, 2024

marco-ippolito force-pushed the fix/baking-for-lts branch from 4a4d262 to 539fc30 Compare

May 8, 2024 13:28

targos reviewed

May 8, 2024

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the fix/baking-for-lts branch from 539fc30 to ad3d5ad Compare

May 8, 2024 13:32


          doc: exclude commits with baking-for-lts

a17694b

marco-ippolito force-pushed the fix/baking-for-lts branch from ad3d5ad to a17694b Compare

May 8, 2024 13:33

aduh95 commented May 8, 2024

Copy link

Copy Markdown

Contributor

Is there a way to still include those commits if they have been on Current for long enough?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito commented May 8, 2024

Copy link

Copy Markdown

Member Author

Is there a way to still include those commits if they have been on Current for long enough?

remove the label

aduh95 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

May 8, 2024

View reviewed changes

targos approved these changes

May 8, 2024

View reviewed changes

ruyadorno approved these changes

May 8, 2024

View reviewed changes

richardlau approved these changes

May 8, 2024

View reviewed changes

marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

May 8, 2024

mhdawson approved these changes

May 8, 2024

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

UlisesGascon approved these changes

May 8, 2024

View reviewed changes

UlisesGascon left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label

May 8, 2024

benjamingr approved these changes

May 9, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

May 10, 2024

nodejs-github-bot merged commit dee061a into nodejs:main

May 10, 2024

nodejs-github-bot commented May 10, 2024

Copy link

Copy Markdown

Collaborator

Landed in dee061a

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

May 11, 2024


          doc: exclude commits with baking-for-lts

2dd8f09

PR-URL: #52896
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos mentioned this pull request

May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request

Jun 17, 2024

v20.15.0 proposal #53486

Merged

marco-ippolito added a commit that referenced this pull request

Jun 17, 2024


          doc: exclude commits with baking-for-lts

1e429d1

PR-URL: #52896
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

soophoo pushed a commit to soophoo/node that referenced this pull request

Jun 20, 2024


          doc: exclude commits with baking-for-lts

95898bb

PR-URL: nodejs#52896
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

Reviewers

ruyadorno

ruyadorno approved these changes

benjamingr

benjamingr approved these changes

UlisesGascon

UlisesGascon approved these changes

richardlau

richardlau approved these changes

RafaelGSS

RafaelGSS approved these changes

+2 more reviewers

targos

targos approved these changes

mhdawson

mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

marco-ippolito commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 8, 2024

Uh oh!

Uh oh!

aduh95 commented May 8, 2024

Uh oh!

marco-ippolito commented May 8, 2024

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

UlisesGascon left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 10, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

marco-ippolito commented May 8, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.