GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: include followTags and GPG=TTY mention by RafaelGSS · Pull Request #52906 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented May 8, 2024

Copy link
Copy Markdown
Member

I have noticed these points missing while helping Marco in the last Node.js 20 release (v20.13.0)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mertcanaltin reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@RafaelGSS
doc: mention push.followTags config
e50db68 
This has happened in v20.13.0 release. Adding this doc
to prevent edge cases where the releaser will sign and push
but won't be able to promote the release.
@nodejs-github-bot

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 8, 2024
marco-ippolito
marco-ippolito reviewed May 8, 2024
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
doc: mention GPG=$(TTY) when signing tag
a636af1
@RafaelGSS
RafaelGSS force-pushed the doc-improve-release-process branch from b46bbf8 to a636af1 Compare May 8, 2024 18:12
@RafaelGSS

RafaelGSS commented May 8, 2024

Copy link
Copy Markdown
Member Author

cc: @nodejs/releasers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 8, 2024
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 8, 2024
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
UlisesGascon
UlisesGascon approved these changes May 8, 2024
View reviewed changes

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ShogunPanda
ShogunPanda approved these changes May 9, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes May 9, 2024
View reviewed changes
@RafaelGSS @aduh95
Apply suggestions from code review
a3925d9 
Co-authored-by: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 12, 2024
aduh95
aduh95 approved these changes May 12, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 12, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 06619aa into nodejs:main May 12, 2024
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

Landed in 06619aa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@RafaelGSS @targos
doc: mention push.followTags config
15db3ef 
This has happened in v20.13.0 release. Adding this doc
to prevent edge cases where the releaser will sign and push
but won't be able to promote the release.

PR-URL: #52906
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@RafaelGSS @marco-ippolito
doc: mention push.followTags config
be309bd 
This has happened in v20.13.0 release. Adding this doc
to prevent edge cases where the releaser will sign and push
but won't be able to promote the release.

PR-URL: #52906
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@RafaelGSS @soophoo
doc: mention push.followTags config
1fe722c 
This has happened in v20.13.0 release. Adding this doc
to prevent edge cases where the releaser will sign and push
but won't be able to promote the release.

PR-URL: nodejs#52906
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RafaelGSS @nodejs-github-bot @ShogunPanda @UlisesGascon @aduh95 @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.