GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: remove deprecated calls for argument groups by VoltrexKeyva · Pull Request #52913 · nodejs/node

Conversation

@VoltrexKeyva

@VoltrexKeyva VoltrexKeyva commented May 9, 2024

Copy link
Copy Markdown
Contributor

I'm not sure what the purpose of these add_argument_group() calls are that pass in an existing argument group but they are deprecated and may be removed, see the Python documentation for notice.

Warning

Changed in version 3.11: Calling add_argument_group() on an
argument group is deprecated. This feature was never supported and
does not always work correctly. The function exists on the API by
accident through inheritance and will be removed in the future.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels May 9, 2024
@VoltrexKeyva
build: remove deprecated calls for argument groups
4b828b4
Remove calls of `add_argument_group()` where an existing argument group
is passed as an argument, this is deprecated since Python 3.11.
@VoltrexKeyva
VoltrexKeyva force-pushed the rm-deprecated-calls branch from a38d71d to 4b828b4 Compare May 9, 2024 02:12
benjamingr
benjamingr approved these changes May 9, 2024
View reviewed changes
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 9, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 9, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes May 9, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59067/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VoltrexKeyva VoltrexKeyva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 9, 2024
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label May 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c70fa2c into nodejs:main May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in c70fa2c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VoltrexKeyva
VoltrexKeyva deleted the rm-deprecated-calls branch May 11, 2024 02:04
targos pushed a commit that referenced this pull request May 11, 2024
@VoltrexKeyva @targos
build: remove deprecated calls for argument groups
b463385
Remove calls of `add_argument_group()` where an existing argument group
is passed as an argument, this is deprecated since Python 3.11.

PR-URL: #52913
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@VoltrexKeyva @marco-ippolito
build: remove deprecated calls for argument groups
48c15d0
Remove calls of `add_argument_group()` where an existing argument group
is passed as an argument, this is deprecated since Python 3.11.

PR-URL: #52913
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@VoltrexKeyva @soophoo
build: remove deprecated calls for argument groups
2c6e52d
Remove calls of `add_argument_group()` where an existing argument group
is passed as an argument, this is deprecated since Python 3.11.

PR-URL: nodejs#52913
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@VoltrexKeyva @nodejs-github-bot @benjamingr @lpinca @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.