GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — path: fix toNamespacedPath on Windows by huseyinacacak-janea · Pull Request #52915 · nodejs/node

Conversation

@huseyinacacak-janea

@huseyinacacak-janea huseyinacacak-janea commented May 9, 2024

Copy link
Copy Markdown
Contributor

There was an inconsistency in the implementation of win32.toNamespacedPath(). It appears that the forward slash / wasn't consistently being converted to a backslash \. This PR fixes this issue by returning resolvedPath in the toNamespacedPath().

I've also added a test case to make sure that there will not be any regression.

Fixes: #30224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
btsimonh reacted with thumbs up emoji bricss and ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 2 reactions
@huseyinacacak-janea
path: fix toNamespacedPath on Windows
2024870
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels May 9, 2024
benjamingr
benjamingr approved these changes May 9, 2024
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 9, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 9, 2024
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59052/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
avivkeller
avivkeller approved these changes May 9, 2024
View reviewed changes

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tip

My review, while it shows my support, is not blocking/approving.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes May 9, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59065/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea

huseyinacacak-janea commented May 13, 2024

Copy link
Copy Markdown
Contributor Author

Is there anything else I can do to help this PR move forward?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2024
@nodejs-github-bot
nodejs-github-bot merged commit dcd8b82 into nodejs:main May 13, 2024
@nodejs-github-bot

nodejs-github-bot commented May 13, 2024

Copy link
Copy Markdown
Collaborator

Landed in dcd8b82
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 15, 2024
@huseyinacacak-janea @targos
path: fix toNamespacedPath on Windows
609d90b 
PR-URL: #52915
Fixes: #30224
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request May 15, 2024
v22.2.0 release proposal #52971
Merged
@huseyinacacak-janea huseyinacacak-janea mentioned this pull request May 15, 2024
fs: move ToNamespacedPath to c++ #52135
Merged
@dylan-conway dylan-conway mentioned this pull request May 27, 2024
fix(node:path): toNamespacedPath bugfix oven-sh/bun#11406
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@huseyinacacak-janea @marco-ippolito
path: fix toNamespacedPath on Windows
f82d086 
PR-URL: #52915
Fixes: #30224
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@huseyinacacak-janea @soophoo
path: fix toNamespacedPath on Windows
d1a3fdd 
PR-URL: nodejs#52915
Fixes: nodejs#30224
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@avivkeller avivkeller avivkeller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent results for path.toNamespacedPath() for win32 UNC paths

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@huseyinacacak-janea @nodejs-github-bot @benjamingr @lpinca @avivkeller @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.