GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: specify that preloaded modules affect subprocesses by avivkeller · Pull Request #52939 · nodejs/node

Conversation

@avivkeller

@avivkeller avivkeller commented May 10, 2024

Copy link
Copy Markdown
Member

Fixes #52930

Marking author as Co-Author, as they specified where the preloaded modules will appear.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
timfish, klaemo, and hasezoey reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@avivkeller @timfish
doc: specify that preloaded modules affect subprocesses
220e29a 
Co-Authored-By: Tim Fish <[email protected]>
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command-line interface. doc Issues and PRs related to Node.js documentation. labels May 10, 2024
@avivkeller avivkeller added the loaders Issues and PRs related to ES module loaders. label Jun 2, 2024
@avivkeller avivkeller added the review wanted PRs that need review. label Aug 9, 2024
@avivkeller

avivkeller commented Aug 9, 2024

Copy link
Copy Markdown
Member Author

Hey, this hasn't seen any reviews or objections, just bumping it a bit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 11, 2024
View reviewed changes
@avivkeller

avivkeller commented Aug 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@jasnell I think this is good to land?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Sep 4, 2024
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2bd6a57 into nodejs:main Sep 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2bd6a57
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@avivkeller @timfish @aduh95
doc: specify that preloaded modules affect subprocesses
de225f5 
Co-Authored-By: Tim Fish <[email protected]>
PR-URL: #52939
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
This was referenced Feb 4, 2025
miggration from 8.11.4 to 10.1.3 memory shortage on github action typegoose/mongodb-memory-server#907
Closed
Node forking will include any --import from the original command typegoose/mongodb-memory-server#912
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cli Issues and PRs related to the Node.js command-line interface. doc Issues and PRs related to Node.js documentation. loaders Issues and PRs related to ES module loaders. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document more clearly that --require and --import can impact all threads and forked processes

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@avivkeller @nodejs-github-bot @jasnell @Trott @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.