GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add --certify-safe to ncu-ci by mcollina · Pull Request #52940 · nodejs/node

Conversation

@mcollina

@mcollina mcollina commented May 11, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes nodejs/node-core-utils#801

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcollina
tools: add --certify-safe to nci-ci
ecc4114 
Signed-off-by: Matteo Collina <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina
mcollina requested a review from aduh95 May 11, 2024 06:39
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 11, 2024
@mcollina mcollina added the tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. label May 11, 2024
@mcollina mcollina mentioned this pull request May 11, 2024
Allowing using request-ci label for collaborators in unapproved PRs nodejs/node-core-utils#801
Closed
benjamingr
benjamingr approved these changes May 11, 2024
View reviewed changes
jasnell
jasnell approved these changes May 11, 2024
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 11, 2024
@github-actions

github-actions Bot commented May 11, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
mcollina, anonrig, MoLow, and rluvaton reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Fixes nodejs/node-core-utils#801

nodejs/node-core-utils#806 would be a fix, this is more of a workaround. I still need help for writing tests BTW
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig changed the title tools: add --certify-safe to nci-ci tools: add --certify-safe to ncu-ci May 11, 2024
MoLow
MoLow approved these changes May 11, 2024
View reviewed changes
lpinca
lpinca approved these changes May 11, 2024
View reviewed changes
@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 12, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 0fa07d4 into nodejs:main May 12, 2024
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

Landed in 0fa07d4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@mcollina @targos
tools: add --certify-safe to nci-ci
afe39ed 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #52940
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@aduh95 aduh95 mentioned this pull request May 22, 2024
Revert "tools: add --certify-safe to ncu-ci" #53098
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@mcollina @marco-ippolito
tools: add --certify-safe to nci-ci
f6290bc 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #52940
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@mcollina @soophoo
tools: add --certify-safe to nci-ci
620563c 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#52940
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 Awaiting requested review from aduh95

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory. tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allowing using request-ci label for collaborators in unapproved PRs

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mcollina @nodejs-github-bot @aduh95 @jasnell @benjamingr @lpinca @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.