GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix watch mode race condition by MoLow · Pull Request #52954 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 12, 2024

Copy link
Copy Markdown
Member

Fixes #52936

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
drk-mtr reacted with thumbs up emoji bricss reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 12, 2024
benjamingr
benjamingr approved these changes May 12, 2024
View reviewed changes
benjamingr
benjamingr reviewed May 12, 2024
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the fix-test-runner-watch-mode branch from b03a4ae to 6d33ed0 Compare May 12, 2024 09:05
@MoLow
MoLow requested review from aduh95 and benjamingr May 12, 2024 09:05
marco-ippolito
marco-ippolito approved these changes May 12, 2024
View reviewed changes
benjamingr
benjamingr approved these changes May 12, 2024
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 12, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 12, 2024
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59170/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes May 12, 2024
View reviewed changes
anonrig
anonrig reviewed May 12, 2024
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 12, 2024
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
test_runner: fix watch mode race condition
65586fd
@MoLow
MoLow requested a review from aduh95 May 13, 2024 06:42
@MoLow
MoLow force-pushed the fix-test-runner-watch-mode branch from 6d33ed0 to 65586fd Compare May 13, 2024 06:43
@nodejs-github-bot

nodejs-github-bot commented May 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59200/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59201/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow requested a review from benjamingr May 13, 2024 10:23
benjamingr
benjamingr approved these changes May 13, 2024
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 14, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c165751 into nodejs:main May 14, 2024
@nodejs-github-bot

nodejs-github-bot commented May 14, 2024

Copy link
Copy Markdown
Collaborator

Landed in c165751
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the fix-test-runner-watch-mode branch May 14, 2024 20:17
targos pushed a commit that referenced this pull request May 15, 2024
@MoLow @targos
test_runner: fix watch mode race condition
a814e72 
PR-URL: #52954
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request May 15, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@MoLow @marco-ippolito
test_runner: fix watch mode race condition
0289a02 
PR-URL: #52954
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@MoLow @soophoo
test_runner: fix watch mode race condition
d14eeb4 
PR-URL: nodejs#52954
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments
@benjamingr benjamingr benjamingr approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
@aduh95 aduh95 Awaiting requested review from aduh95

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Watch mode duplicates and fails on second run

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@MoLow @nodejs-github-bot @benjamingr @anonrig @aduh95 @marco-ippolito @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.