GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update repo docs to use 'CTC' by orangemocha · Pull Request #5304 · nodejs/node

Conversation

@orangemocha

@orangemocha orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orangemocha orangemocha mentioned this pull request Feb 18, 2016
doc: contribution guidelines for node-chakracore nodejs/node-chakracore#27
Open
@cjihrig

cjihrig commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123

Fishrock123 commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

Rubber-stamp LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thefourtheye
thefourtheye reviewed Feb 18, 2016
View reviewed changes
Comment thread WORKING_GROUPS.md Outdated

@thefourtheye thefourtheye Feb 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, if I understand correctly CTC is purely a technical body. So this should be TSC only I guess

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fishrock123 Fishrock123 Feb 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm right, more language needs to be updated. Technically it is the CTC that charters WG's to work on core, but this probably is still outdated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@orangemocha orangemocha Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, it doesn't contemplate that WGs can be created at the TSC level too? How about if we renamed this section to "Node.js Core Working Groups"? Not sure if we need to mention here that there is a level above Core (TSC and TSC chartered WGs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fishrock123 Fishrock123 Feb 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Node.js Core Working Groups"?

That could work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@thefourtheye thefourtheye Feb 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have non-core work groups right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@orangemocha orangemocha Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There exist non-core Working Groups in the Node.js Foundation, which report to the TSC. There can also be other working groups that report to other Top Level Projects (e.g. Express or libuv).
I don't think it's strictly necessary for this doc to describe the whole hierarchy, and things that it doesn't have a governance over, though it could certainly be improved (perhaps with a link). Maybe room for another PR? :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@thefourtheye thefourtheye Feb 19, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks for clarifying :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fishrock123 Fishrock123 added the doc Issues and PRs related to Node.js documentation. label Feb 18, 2016
@orangemocha
doc: update repo docs to use 'CTC'
bca58f9
@orangemocha
orangemocha force-pushed the orangemocha-docs branch from 5c04d26 to bca58f9 Compare February 18, 2016 23:19
@orangemocha

orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

Updated WORKING_GROUPS.md to refer to working groups as "Node.js Core Working Groups" in the title and first sentence of the doc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orangemocha

orangemocha commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

FYI @nodejs/ctc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Feb 19, 2016

Copy link
Copy Markdown
Member

Lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
orangemocha added a commit that referenced this pull request Feb 22, 2016
@orangemocha
doc: update repo docs to use 'CTC'
18abb3c 
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@orangemocha

orangemocha commented Feb 22, 2016

Copy link
Copy Markdown
Contributor Author

Landed with 18abb3c. Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orangemocha orangemocha closed this Feb 22, 2016
rvagg pushed a commit that referenced this pull request Feb 23, 2016
@orangemocha @rvagg
doc: update repo docs to use 'CTC'
a8862f5 
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell added the lts-watch-v4.x label Feb 26, 2016
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@orangemocha Myles Borins
doc: update repo docs to use 'CTC'
d4d1446 
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Mar 1, 2016
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@orangemocha Myles Borins
doc: update repo docs to use 'CTC'
e0b45e4 
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@orangemocha Myles Borins
doc: update repo docs to use 'CTC'
3d10afa 
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@orangemocha @cjihrig @Fishrock123 @jasnell @thefourtheye @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.