GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [v20.x] vm: harden module type checks by legendecas · Pull Request #53109 · nodejs/node

Conversation

legendecas commented May 22, 2024

Copy link

Copy Markdown

Member

Check if the value returned from user linker function is a null-ish value.

validateInternalField should be preferred when checking this argument to guard against null-ish this.

Co-authored-by: Mike Ralphson [email protected]
PR-URL: #52162
Reviewed-By: Vinícius Lourenço Claro Cardoso [email protected]
Reviewed-By: Yagiz Nizipli [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added needs-ci

PRs that need a full CI run.

v20.x vm Issues and PRs related to the vm subsystem. labels

May 22, 2024

legendecas mentioned this pull request

May 22, 2024

vm: harden module type checks #52162

Merged

anonrig approved these changes

May 22, 2024

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 23, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 23, 2024

nodejs-github-bot commented May 23, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59366/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito approved these changes

May 23, 2024

View reviewed changes

nodejs-github-bot commented Jun 12, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59732/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the backport-52162-to-20 branch from ed17172 to f9c85f3 Compare

June 12, 2024 07:42

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 17, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 17, 2024

nodejs-github-bot commented Jun 17, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59832/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the v20.x-staging branch 2 times, most recently from d702971 to 044bcce Compare

June 17, 2024 14:26

joyeecheung reviewed

Jun 17, 2024

View reviewed changes

Comment thread

lib/internal/vm/module.js Outdated

joyeecheung Jun 17, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the freezing (from #49720) semver-major?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marco-ippolito requested changes

Jun 17, 2024

View reviewed changes

marco-ippolito left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on #53109 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          vm: harden module type checks

5081f84

Check if the value returned from user linker function is a null-ish
value.

`validateInternalField` should be preferred when checking `this`
argument to guard against null-ish `this`.

Co-authored-by: Mike Ralphson <[email protected]>
PR-URL: nodejs#52162
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

legendecas force-pushed the backport-52162-to-20 branch from f9c85f3 to 5081f84 Compare

June 18, 2024 09:10

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 18, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59856/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the v20.x-staging branch from a924e20 to 473fa73 Compare

June 19, 2024 09:12

marco-ippolito force-pushed the v20.x-staging branch from 91dea21 to 44268c2 Compare

August 19, 2024 08:33

targos approved these changes

Sep 21, 2024

View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 21, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 21, 2024

nodejs-github-bot commented Sep 21, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62621/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Sep 21, 2024

Copy link

Copy Markdown

Member

@marco-ippolito I believe the comment has been addressed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito approved these changes

Sep 21, 2024

View reviewed changes

nodejs-github-bot commented Sep 25, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62768/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 26, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62781/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

Sep 26, 2024


          vm: harden module type checks

f88bf05

Check if the value returned from user linker function is a null-ish
value.

`validateInternalField` should be preferred when checking `this`
argument to guard against null-ish `this`.

Co-authored-by: Mike Ralphson <[email protected]>
PR-URL: #52162
Backport-PR-URL: #53109
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

targos commented Sep 26, 2024

Copy link

Copy Markdown

Member

Landed in f88bf05

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos closed this

Sep 26, 2024

legendecas deleted the backport-52162-to-20 branch

September 26, 2024 08:46

targos pushed a commit that referenced this pull request

Oct 2, 2024


          vm: harden module type checks

47be236

Check if the value returned from user linker function is a null-ish
value.

`validateInternalField` should be preferred when checking `this`
argument to guard against null-ish `this`.

Co-authored-by: Mike Ralphson <[email protected]>
PR-URL: #52162
Backport-PR-URL: #53109
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

targos pushed a commit that referenced this pull request

Oct 2, 2024


          vm: harden module type checks

9e1c229

Check if the value returned from user linker function is a null-ish
value.

`validateInternalField` should be preferred when checking `this`
argument to guard against null-ish `this`.

Co-authored-by: Mike Ralphson <[email protected]>
PR-URL: #52162
Backport-PR-URL: #53109
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewers

joyeecheung

joyeecheung left review comments

anonrig

anonrig approved these changes

marco-ippolito

marco-ippolito approved these changes

+1 more reviewer

targos

targos approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.