GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update c-ares to 1.29.0 by nodejs-github-bot · Pull Request #53155 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.29.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label May 26, 2024
@nodejs-github-bot

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/net
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels May 26, 2024
@lpinca
lpinca force-pushed the actions/tools-update-c-ares branch from 6fb3d30 to 8e2ec74 Compare May 26, 2024 07:31
lpinca
lpinca reviewed May 26, 2024
View reviewed changes
Comment thread deps/cares/src/lib/thirdparty/apple/dnsinfo.h
@@ -0,0 +1,128 @@
/*

@lpinca lpinca May 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not included in the release tarball, see c-ares/c-ares#763.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2024
lpinca
lpinca approved these changes May 26, 2024
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
VoltrexKeyva
VoltrexKeyva approved these changes May 26, 2024
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
targos
targos approved these changes May 27, 2024
View reviewed changes
RafaelGSS
RafaelGSS approved these changes May 27, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59496/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 30, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59549/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes May 31, 2024
View reviewed changes
nodejs-github-bot and others added 2 commits June 1, 2024 20:29
@nodejs-github-bot @lpinca
deps: update c-ares to 1.29.0
3c850a5
@lpinca
fixup! deps: update c-ares to 1.29.0
5c37cba
@lpinca
lpinca force-pushed the actions/tools-update-c-ares branch from 8e2ec74 to 5c37cba Compare June 1, 2024 18:30
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 1, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 1, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59605/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jun 2, 2024
View reviewed changes
@lpinca lpinca added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 41d90aa into main Jun 2, 2024
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-c-ares branch June 2, 2024 05:30
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in 41d90aa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jun 3, 2024
@nodejs-github-bot @targos
deps: update c-ares to 1.29.0
257004c 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
v22.3.0 proposal #53379
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @soophoo
deps: update c-ares to 1.29.0
fdb3a5b 
PR-URL: nodejs#53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@zcbenz zcbenz mentioned this pull request Jul 2, 2024
build: fix mac build error of c-ares under GN #53687
Merged
@targos targos added lts-watch-v18.x labels Jul 5, 2024
@targos targos mentioned this pull request Jul 5, 2024
dns.resolveMx returns invalid result in Node <22 #53708
Closed
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@nodejs-github-bot @marco-ippolito
deps: update c-ares to 1.29.0
7a126e8 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
v20.16.0 proposal #53945
Merged
codebytere added a commit to electron/electron that referenced this pull request Jul 25, 2024
@codebytere
deps: update c-ares to 1.29.0
2b571bc 
nodejs/node#53155
codebytere added a commit to electron/electron that referenced this pull request Jul 26, 2024
@codebytere
deps: update c-ares to 1.29.0
217bcd4 
nodejs/node#53155
jkleinsc pushed a commit to electron/electron that referenced this pull request Jul 26, 2024
@electron-roller @codebytere @VerteDinde
chore: bump node to v20.16.0 (main) (#43029)
b3d52c0 
* chore: bump node in DEPS to v20.16.0

* test: skip unstable shadow realm gc tests

nodejs/node#52855

* test: extend env for `test-node-output-errors`

nodejs/node#53535

* src: fix typo in env.cc

nodejs/node#53418

* src: reset `process.versions` during pre-execution

nodejs/node#53444

* chore: fixup patch indices

* src,permission: --allow-wasi & prevent WASI exec

nodejs/node#53124

* tls: use SSL_get_peer_tmp_key

nodejs/node#53366

* deps: update c-ares to 1.29.0

nodejs/node#53155

* src: account for OpenSSL unexpected version

* crypto: fix propagation of "memory limit exceeded"

nodejs/node#53300

* process: add process.getBuiltinModule(id)

nodejs/node#52762

* windows 32bit: config change callback needs to be stdcall

c-ares/c-ares@8f265c9

* fix: building with UNICODE

c-ares/c-ares#802

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: Keeley Hammond <[email protected]>
@targos targos removed the lts-watch-v20.x label Sep 30, 2024
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@nodejs-github-bot @aduh95
deps: update c-ares to 1.29.0
6ba8bc0 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@aduh95 aduh95 added backported-to-v18.x and removed lts-watch-v18.x labels Nov 2, 2024
@aduh95 aduh95 mentioned this pull request Nov 7, 2024
2024-11-12, Version 18.20.5 'Hydrogen' (LTS) #55768
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+2 more reviewers
@targos targos targos approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nodejs-github-bot @lpinca @targos @RafaelGSS @marco-ippolito @VoltrexKeyva @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.