GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — vm,src: add property query interceptors by targos · Pull Request #53172 · nodejs/node

Conversation

@targos

@targos targos commented May 27, 2024

Copy link
Copy Markdown
Member

Fixes: #52720

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and avivkeller reacted with rocket emoji
All reactions
  • 🚀 2 reactions
@targos
vm,src: add property query interceptors
082d09d 
Fixes: nodejs#52720
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 27, 2024
@targos

targos commented May 27, 2024

Copy link
Copy Markdown
Member Author

/cc @nodejs/cpp-reviewers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
fixup
0cf3a9e
@targos targos mentioned this pull request May 27, 2024
Inconsistent presence of property in contextified object #52720
Closed
@targos

targos commented May 28, 2024

Copy link
Copy Markdown
Member Author

@nodejs/vm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes May 28, 2024
View reviewed changes
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 28, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 28, 2024
@nodejs-github-bot

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59488/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added dont-land-on-v18.x commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 28, 2024
@targos

targos commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

Can someone else please review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d1f18b0 into nodejs:main Jun 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in d1f18b0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the fix-52720 branch June 4, 2024 06:55
@tsctx tsctx mentioned this pull request Jun 5, 2024
vm module regression #53346
Closed
@targos targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 5, 2024
@targos targos mentioned this pull request Jun 5, 2024
Revert "vm,src: add property query interceptors" #53348
Merged
@legendecas legendecas mentioned this pull request Jun 20, 2024
vm,src: add property query interceptors #53517
Closed
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
vm,src: add property query interceptors
b8fbf34 
Fixes: nodejs#52720
PR-URL: nodejs#53172
Reviewed-By: Joyee Cheung <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent presence of property in contextified object

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@targos @nodejs-github-bot @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.