GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools,doc: parse types in braces everywhere by estliberitas · Pull Request #5329 · nodejs/node

Conversation

@estliberitas

@estliberitas estliberitas commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

Also add EvalError, RangeError, ReferenceError, SyntaxError,
TypeError, URIError to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
estliberitas
estliberitas reviewed Feb 19, 2016
View reviewed changes
Comment thread tools/doc/html.js Outdated

@estliberitas estliberitas Feb 19, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have side effects, only if we will write something like....

Some missing {type} or { code: 'without backquote' }

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mscdex mscdex added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Feb 19, 2016
jasnell
jasnell reviewed Feb 19, 2016
View reviewed changes
Comment thread doc/api/errors.markdown Outdated

@jasnell jasnell Feb 19, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these links?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@estliberitas estliberitas Feb 20, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention #5325 in a commit. This is why actually I created PR. #5325 in turn was caused by #5322

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@stevemao stevemao Apr 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @estliberitas , since #5641 fixes the broken links, do we still need to remove them?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell jasnell added the lts-watch-v4.x label Feb 19, 2016
@jasnell

jasnell commented Feb 20, 2016

Copy link
Copy Markdown
Member

+1... ok, LGTM!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@silverwind

silverwind commented Feb 27, 2016

Copy link
Copy Markdown
Contributor

This needs a rebase now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@estliberitas

estliberitas commented Feb 27, 2016

Copy link
Copy Markdown
Contributor Author

@silverwind Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@estliberitas estliberitas mentioned this pull request Mar 10, 2016
doc: fix markdown links #5641
Closed
@jasnell

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member

Oy.. looks like it needs another rebase. If you can get that I'll look at landing next week
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@estliberitas

estliberitas commented Apr 2, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell I'll fix tmrw
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@estliberitas
tools,doc: parse types in braces everywhere
220e2d7 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.
@estliberitas

estliberitas commented Apr 4, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Apr 4, 2016

Copy link
Copy Markdown
Member

@nodejs/documentation ... another quick review please? :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

ping @jasnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Apr 18, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Apr 18, 2016
@estliberitas @jasnell
tools,doc: parse types in braces everywhere
eafd31a 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Apr 18, 2016

Copy link
Copy Markdown
Member

Landed in eafd31a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
3a6d776 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
07484a9 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
2567f2d 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
V5.10.2 proposal #6311
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
d516412 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 21, 2016
V5.11.0 proposal #6321
Closed
V5.11.0 proposal #6322
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@estliberitas @MylesBorins
tools,doc: parse types in braces everywhere
0658632 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@estliberitas @joelostrowski
tools,doc: parse types in braces everywhere
2620716 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: nodejs#5325.
PR-URL: nodejs#5329
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@estliberitas @jasnell
tools,doc: parse types in braces everywhere
df9e6fb 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 3, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
aeea832 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
ab7f3dd 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels May 17, 2016
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@estliberitas Myles Borins
tools,doc: parse types in braces everywhere
c893cd3 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
v4.4.5 proposal #6824
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@estliberitas @jasnell @silverwind @eljefedelrodeodeljefe @stevemao @mscdex @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.