GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module,win: fix long path resolve by huseyinacacak-janea · Pull Request #53294 · nodejs/node

Conversation

@huseyinacacak-janea

@huseyinacacak-janea huseyinacacak-janea commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

Several issues were encountered with module loading due to extended path lengths on Windows. These have been addressed with corrections implemented across four distinct code locations, accompanied by the addition of a corresponding test case for each to ensure functionality.
Additionally, I've moved es-module/test-GH-50753.js to es-module/test-esm-long-path-win.js as the tests cover more cases than specified in that issue.

Fixes: #50753

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Jun 3, 2024
@targos

targos commented Jun 3, 2024

Copy link
Copy Markdown
Member

@nodejs/platform-windows
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea
huseyinacacak-janea force-pushed the huseyin-11801-long-path-error branch from 3ee742c to 27a4505 Compare June 3, 2024 12:11
H4ad
H4ad previously approved these changes Jun 3, 2024
View reviewed changes
@H4ad
H4ad dismissed their stale review June 3, 2024 12:53

I actually need more time to take a look, I think the implementation will solve the problem but I want to test in which cases we should include the UNC path, since we didn't do this in all paths in the toNamespacedPath.

@H4ad

H4ad commented Jun 3, 2024

Copy link
Copy Markdown
Member

There are some conditions to include the UNC that you are not following:

node/lib/path.js

Lines 632 to 645 in 58711c2

if (StringPrototypeCharCodeAt(resolvedPath, 0) === CHAR_BACKWARD_SLASH) {
// Possible UNC root
if (StringPrototypeCharCodeAt(resolvedPath, 1) === CHAR_BACKWARD_SLASH) {
const code = StringPrototypeCharCodeAt(resolvedPath, 2);
if (code !== CHAR_QUESTION_MARK && code !== CHAR_DOT) {
// Matched non-long UNC root, convert the path to a long UNC path
return `\\\\?\\UNC\\${StringPrototypeSlice(resolvedPath, 2)}`;
}
}
} else if (
isWindowsDeviceRoot(StringPrototypeCharCodeAt(resolvedPath, 0)) &&
StringPrototypeCharCodeAt(resolvedPath, 1) === CHAR_COLON &&
StringPrototypeCharCodeAt(resolvedPath, 2) === CHAR_BACKWARD_SLASH
) {

Although the condition could be matched, I think it would be better to wait for the migration of toNamespacedPath to C++.

Maybe we could include the ToNamespacePath port in this PR, and then leave that other PR just to remove the JS version and rewrite the places they are used.

@anonrig What do you think?
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 3, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59635/
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig requested changes Jun 3, 2024
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to land this after the toNamespacedPath migration to C++. Unfortunately, I don't have the time to pursue this at the moment (afaict, there is only one failing test). I appreciate if you could took over that PR and apply these changes in a follow up PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction
@MoLow

MoLow commented Jun 3, 2024

Copy link
Copy Markdown
Member

I prefer to land this after the toNamespacedPath migration to C++. Unfortunately, I don't have the time to pursue this at the moment (afaict, there is only one failing test). I appreciate if you could took over that PR and apply these changes in a follow up PR.

in that case, can you convert the blocking "request changes" into a simple suggestion/friendly ask? I don't think this PR should be blocked on a PR that is not being currently worked on
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59644/
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea

huseyinacacak-janea commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

I prefer to land this after the toNamespacedPath migration to C++. Unfortunately, I don't have the time to pursue this at the moment (afaict, there is only one failing test). I appreciate if you could took over that PR and apply these changes in a follow up PR.

Sure, no problem, I'll take over your PR and start working on it.
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea
huseyinacacak-janea force-pushed the huseyin-11801-long-path-error branch from 27a4505 to 42b88bf Compare July 1, 2024 09:31
@huseyinacacak-janea
module,win: fix long path resolve
14a1de0
@huseyinacacak-janea
huseyinacacak-janea force-pushed the huseyin-11801-long-path-error branch from 42b88bf to 14a1de0 Compare July 2, 2024 05:37
@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 2, 2024
H4ad
H4ad approved these changes Jul 2, 2024
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60050/
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea

huseyinacacak-janea commented Jul 5, 2024

Copy link
Copy Markdown
Contributor Author

I prefer to land this after the toNamespacedPath migration to C++. Unfortunately, I don't have the time to pursue this at the moment (afaict, there is only one failing test). I appreciate if you could took over that PR and apply these changes in a follow up PR.

@anonrig I've rebased this PR to use toNamespacedPath. Could you please review it?
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea

huseyinacacak-janea commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

Is there anything else I can do to help this PR move forward?
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with heart emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad
H4ad requested a review from anonrig July 15, 2024 12:01
anonrig
anonrig reviewed Jul 15, 2024
View reviewed changes
Comment thread src/node_file.cc Outdated
switch (FilePathIsFile(env, file_path)) {
Local<Value> local_file_path =
Buffer::Copy(
env->isolate(), file_path.c_str(), strlen(file_path.c_str()))

@anonrig anonrig Jul 2, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env->isolate(), file_path.c_str(), strlen(file_path.c_str()))
env->isolate(), file_path.c_str(), file_path.size())

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huseyinacacak-janea huseyinacacak-janea Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/node_file.cc Outdated
switch (FilePathIsFile(env, file_path)) {
Local<Value> local_file_path =
Buffer::Copy(
env->isolate(), file_path.c_str(), strlen(file_path.c_str()))

@anonrig anonrig Jul 15, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huseyinacacak-janea huseyinacacak-janea Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/node_modules.cc Outdated
// Check if the path has a trailing slash. If so, add it after
// ToNamespacedPath() as it will be deleted by ToNamespacedPath()
bool slashCheck = !path_value.ToString().empty() &&
path_value.ToString().back() ==

@anonrig anonrig Jul 15, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path_value.ToString().back() ==
path_value.ToStringView().ends_with

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huseyinacacak-janea huseyinacacak-janea Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/node_modules.cc Outdated
// Check if the path has a trailing slash. If so, add it after
// ToNamespacedPath() as it will be deleted by ToNamespacedPath()
bool slashCheck = !path_value.ToString().empty() &&
path_value.ToString().back() ==

@anonrig anonrig Jul 15, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huseyinacacak-janea huseyinacacak-janea Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@huseyinacacak-janea
fixup! module,win: fix long path resolve
dae0bfe
anonrig
anonrig reviewed Jul 15, 2024
View reviewed changes
Comment thread src/node_modules.cc Outdated
bool slashCheck = !path_value.ToString().empty() &&
path_value.ToString().back() ==
std::filesystem::path::preferred_separator;
path_value.ToStringView().ends_with(

@anonrig anonrig Jul 15, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous line is not needed path_value.ToString() creates an unnecessary string.

Can you also remove this in other places?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huseyinacacak-janea huseyinacacak-janea Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anonrig
anonrig reviewed Jul 15, 2024
View reviewed changes
Comment thread src/node_file.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea
fixup! module,win: fix long path resolve
0e2c739
@huseyinacacak-janea

huseyinacacak-janea commented Jul 26, 2024

Copy link
Copy Markdown
Contributor Author

I've fixed the suggestions. Is there anything else I can do to help this PR move forward?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuantumQuin

QuantumQuin commented Aug 7, 2024

Copy link
Copy Markdown

@anonrig Is there anything else we can do to help this PR move forward? I'm having many issues with long paths on Windows and am eager to get this fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 7, 2024
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60944/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60972/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60974/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@huseyinacacak-janea

huseyinacacak-janea commented Aug 9, 2024

Copy link
Copy Markdown
Contributor Author

The failing test in the CI is a known flaky test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60987/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad H4ad added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 37f9eca into nodejs:main Aug 10, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in 37f9eca
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Aug 14, 2024
@huseyinacacak-janea @targos
module,win: fix long path resolve
e676d98 
PR-URL: #53294
Fixes: #50753
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
This was referenced Sep 9, 2024
Upgrade to Node.js 22.7.0 karlhorky/node-js-max_path-windows-bug#2
Open
Long node_modules paths cannot be found on Windows when LongPathsEnabled enabled #50753
Closed
@BalaM314 BalaM314 mentioned this pull request Sep 19, 2024
Node does not determine that a file is an ES module when the package.json is in a long path #54304
Closed
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
@joyeecheung joyeecheung mentioned this pull request Jan 23, 2025
[v20.x backport] src: move package_json_reader cache to c++ #56590
Closed
@wonu wonu mentioned this pull request Feb 28, 2026
Subpath imports (#) fail on Windows when package.json path >= 260 chars (MAX_PATH) #62043
Closed
@DanielForniessoria-TomTom DanielForniessoria-TomTom mentioned this pull request Aug 18, 2026
chore: migrate to pnpm and Biome, and harden the MCPB bundle build tomtom-international/tomtom-traffic-analytics-mcp#37
Merged
17 tasks done
DanielForniessoria-TomTom added a commit to tomtom-international/tomtom-traffic-analytics-mcp that referenced this pull request Aug 18, 2026
@DanielForniessoria-TomTom @claude
docs: justify nodeLinker: hoisted with measured path headroom
f4fa906 
The old comment blamed a Node bug: package.json read silently failing past
MAX_PATH, so `{"type":"module"}` was missed and ESM parsed as CJS. That was
fixed in Node 22.7.0 (nodejs/node#53294, which namespaces fs, ESM resolution
and package.json reads) and this package requires >=22.9.0, so the mechanism
the comment described cannot be why we need the setting.

The reason that does hold up is headroom, measured on this lockfile: the
longest path relative to the repo root is 115 characters hoisted against 190
isolated (at Windows' default virtualStoreDirMaxLength of 60). An ordinary
C:\Users\<first>.<last>\IdeaProjects\tomtom-traffic-analytics-mcp checkout is
63 characters, leaving isolated ~6 before MAX_PATH — a OneDrive-redirected
Documents folder or a worktree subdirectory exceeds it. Enabling long paths
instead needs an admin registry value plus a longPathAware manifest node.exe
does not ship (nodejs/node#40641), which a public repo cannot require.

Also records what the setting does and does not cost, since that was the
review question. It costs strict isolation: an undeclared dependency resolves
locally but breaks in the published bundle. It costs nothing measurable
otherwise — 321 MB and equal install times either way (isolated 4.86/6.65/
5.12s against hoisted 5.82/5.77/5.11s, warm store, frozen lockfile), because
the store dedup comes from packageImportMethod, not from nodeLinker.

Comment only; no behaviour change.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Long node_modules paths cannot be found on Windows when LongPathsEnabled enabled

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@huseyinacacak-janea @targos @H4ad @nodejs-github-bot @MoLow @QuantumQuin @anonrig @StefanStojanovic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.