GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour by jakecastelli · Pull Request #53396 · nodejs/node

Conversation

@jakecastelli

@jakecastelli jakecastelli commented Jun 9, 2024

Copy link
Copy Markdown
Member

Document rejectNonStandardBodyWrites option and its behaviour. Make the documentation clear that rejection only happens when rejectNonStandardBodyWrites is set to true.

Fixes: #53035
Refs: #47732 (comment), #47480

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tonivj5 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@jakecastelli
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
a1f0ebb
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. labels Jun 9, 2024
@jakecastelli
fixup!
1112d97
lpinca
lpinca approved these changes Jun 9, 2024
View reviewed changes
ShogunPanda
ShogunPanda approved these changes Jun 10, 2024
View reviewed changes
UlisesGascon
UlisesGascon approved these changes Jun 10, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Jun 10, 2024
View reviewed changes
@marco-ippolito marco-ippolito added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 10, 2024
mcollina
mcollina approved these changes Jun 11, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/53396
✔  Done loading data for nodejs/node/pull/53396
----------------------------------- PR info ------------------------------------
Title      doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour (#53396)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jakecastelli:fix-53035 -> nodejs:main
Labels     http, doc, author ready
Commits    2
 - doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour
 - fixup!
Committers 1
 - jakecastelli <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/53396
Fixes: https://github.com/nodejs/node/issues/53035
Reviewed-By: Luigi Pinca 
Reviewed-By: Paolo Insogna 
Reviewed-By: Ulises Gascón 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53396
Fixes: https://github.com/nodejs/node/issues/53035
Reviewed-By: Luigi Pinca 
Reviewed-By: Paolo Insogna 
Reviewed-By: Ulises Gascón 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Jun 2024 15:57:36 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53396#pullrequestreview-2106362720
   ✔  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107371369
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107511309
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107859286
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2109979771
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 53396
From https://github.com/nodejs/node
 * branch                  refs/pull/53396/merge -> FETCH_HEAD
✔  Fetched commits as 94c81784422e..1112d9752552
--------------------------------------------------------------------------------
[main 401a614dcc] doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour
 Author: jakecastelli <[email protected]>
 Date: Mon Jun 10 01:24:07 2024 +0930
 1 file changed, 7 insertions(+), 2 deletions(-)
[main b7db59c059] fixup!
 Author: jakecastelli <[email protected]>
 Date: Mon Jun 10 01:31:30 2024 +0930
 1 file changed, 1 insertion(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour

PR-URL: #53396
Fixes: #53035
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Ulises Gascón [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Matteo Collina [email protected]

[detached HEAD eb0ef3eac3] doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
Author: jakecastelli [email protected]
Date: Mon Jun 10 01:24:07 2024 +0930
1 file changed, 7 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!

PR-URL: #53396
Fixes: #53035
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Ulises Gascón [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Matteo Collina [email protected]

[detached HEAD d73e5a0a37] fixup!
Author: jakecastelli [email protected]
Date: Mon Jun 10 01:31:30 2024 +0930
1 file changed, 1 insertion(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9468967820

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito marco-ippolito added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 521c9c6 into nodejs:main Jun 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in 521c9c6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Jun 20, 2024
@jakecastelli @targos
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
24c7a94
PR-URL: #53396
Fixes: #53035
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@jakecastelli @soophoo
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
90c39f9
PR-URL: nodejs#53396
Fixes: nodejs#53035
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Jun 25, 2024
v22.4.0 release proposal #53583
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
## 2024-07-02, Version 22.4.0 (Current), @targos Karliz24/Marley-#16
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@jakecastelli @marco-ippolito
doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
b8944f6
PR-URL: #53396
Fixes: #53035
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
v20.16.0 proposal #53945
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http module documented default behavior only triggered if undocumented option is set

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jakecastelli @nodejs-github-bot @mcollina @ShogunPanda @lpinca @UlisesGascon @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.