GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify error handling in net/createServer by dirceu · Pull Request #5353 · nodejs/node

Conversation

@dirceu

@dirceu dirceu commented Feb 21, 2016

Copy link
Copy Markdown
Contributor

Fixes: #5345

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@evanlucas

evanlucas commented Feb 21, 2016

Copy link
Copy Markdown
Contributor

LGTM.

/cc @trevnorris
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Feb 21, 2016
@dirceu
dirceu force-pushed the fix-5345 branch from 17e2930 to 03625ca Compare February 21, 2016 18:13
@jasnell jasnell added the lts-watch-v4.x label Feb 21, 2016
@jasnell

jasnell commented Feb 21, 2016

Copy link
Copy Markdown
Member

It would be good if the commit log message identified what was clarified a bit more specifically.
Otherwise LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dirceu
dirceu force-pushed the fix-5345 branch from 03625ca to 48b014f Compare February 21, 2016 21:26
@dirceu

dirceu commented Feb 21, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell good point. Can you please check the new commit message?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evanlucas
evanlucas reviewed Feb 21, 2016
View reviewed changes
Comment thread doc/api/net.markdown Outdated

@evanlucas evanlucas Feb 21, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an error listener here as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dirceu
doc: clarify error handling in net.createServer
ecf740c 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: nodejs#5345
PR-URL: nodejs#5353
@dirceu
dirceu force-pushed the fix-5345 branch from 48b014f to ecf740c Compare February 21, 2016 21:53
@trevnorris

trevnorris commented Feb 21, 2016

Copy link
Copy Markdown
Contributor

LGTM. Thanks for looking into this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Feb 23, 2016

Copy link
Copy Markdown
Member

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evanlucas pushed a commit that referenced this pull request Feb 25, 2016
@dirceu @evanlucas
doc: clarify error handling in net.createServer
581606a 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@evanlucas

evanlucas commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Landed in 581606a. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas evanlucas closed this Feb 25, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@dirceu @rvagg
doc: clarify error handling in net.createServer
a0c3d5f 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@dirceu @rvagg
doc: clarify error handling in net.createServer
935fd21 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Release proposal: v5.7.1 #5464
Merged
5 tasks done
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@dirceu Myles Borins
doc: clarify error handling in net.createServer
1d97ce0 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Mar 1, 2016
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@dirceu Myles Borins
doc: clarify error handling in net.createServer
b86540d 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@dirceu Myles Borins
doc: clarify error handling in net.createServer
5b9bcea 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@dirceu @evanlucas @jasnell @trevnorris @benjamingr @mscdex @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.