GeezerVison

- Loading data for nodejs/node/pull/53764
✔  Done loading data for nodejs/node/pull/53764
----------------------------------- PR info ------------------------------------
Title      lib,esm: handle bypass network-import via data: (#53764)
Author     Rafael Gonzaga <[email protected]> (@RafaelGSS)
Branch     RafaelGSS:backport-network-import-via-data -> nodejs:main
Labels     esm, author ready, needs-ci
Commits    1
 - lib,esm: handle bypass network-import via data:
Committers 1
 - RafaelGSS <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/53764
Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2092749
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53764
Fixes: https://hackerone.com/bugs?subject=nodejs&report_id=2092749
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Jul 2024 18:48:45 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53764#pullrequestreview-2164507162
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53764#pullrequestreview-2165404578
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53764#pullrequestreview-2165583758
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53764#pullrequestreview-2165697861
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-07-08T23:19:20Z: https://ci.nodejs.org/job/node-test-pull-request/60188/
- Querying data for job/node-test-pull-request/60188/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 53764
From https://github.com/nodejs/node
 * branch                  refs/pull/53764/merge -> FETCH_HEAD
✔  Fetched commits as fc233627ed44..15c2d8d75ed8
--------------------------------------------------------------------------------
[main ad0ac2de27] lib,esm: handle bypass network-import via data:
 Author: RafaelGSS <[email protected]>
 Date: Wed Jan 10 14:50:18 2024 -0300
 3 files changed, 164 insertions(+), 64 deletions(-)
 create mode 100644 test/fixtures/es-modules/import-data-url.mjs
   ✔  Patches applied
--------------------------------------------------------------------------------
   ⚠  Found Reviewed-By: Antoine du Hamel <[email protected]>, skipping..
   ⚠  Found Reviewed-By: Marco Ippolito <[email protected]>, skipping..
--------------------------------- New Message ----------------------------------
lib,esm: handle bypass network-import via data:
PR-URL: https://github.com/nodejs-private/node-private/pull/522

Refs: https://hackerone.com/bugs?subject=nodejs&amp;report_id=2092749

Reviewed-By: Antoine du Hamel <[email protected]>

Reviewed-By: Marco Ippolito <[email protected]>

CVE-ID: CVE-2024-22020

PR-URL: #53764

Fixes: https://hackerone.com/bugs?subject=nodejs&amp;report_id=2092749

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>
[main 6f2a2306fc] lib,esm: handle bypass network-import via data:

Author: RafaelGSS <[email protected]>

Date: Wed Jan 10 14:50:18 2024 -0300

3 files changed, 164 insertions(+), 64 deletions(-)

create mode 100644 test/fixtures/es-modules/import-data-url.mjs

✖  6f2a2306fcf219dcd27189810a543b542800cbc4

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  7:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  6:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue