GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update nbytes and add update script by anonrig · Pull Request #53790 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Jul 9, 2024

Copy link
Copy Markdown
Member

Adds the update script and actually updates the version to 0.1.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@anonrig
anonrig requested a review from jasnell July 9, 2024 19:29
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 9, 2024
@anonrig
deps: update nbytes and add update script
c5ca7b5
@anonrig
anonrig force-pushed the update-nbytes branch from d6125cb to c5ca7b5 Compare July 9, 2024 19:30
jasnell
jasnell approved these changes Jul 9, 2024
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@marco-ippolito

marco-ippolito commented Jul 10, 2024

Copy link
Copy Markdown
Member

should this go also in node_metadata ? so its visibile from process.version?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Jul 10, 2024

Copy link
Copy Markdown
Member Author

should this go also in node_metadata ? so its visibile from process.version?

We already have nbytes = NBYTES_VERSION; in node_metadata
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Jul 10, 2024

Copy link
Copy Markdown
Member

NBYTES_VERSION

All right, I was just checking to make sure we dont need to update the NBYTES_VERSION version from the update script
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2024 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60226/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Jul 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/53790
✔  Done loading data for nodejs/node/pull/53790
----------------------------------- PR info ------------------------------------
Title      deps: update nbytes and add update script (#53790)
Author     Yagiz Nizipli <[email protected]> (@anonrig)
Branch     anonrig:update-nbytes -> nodejs:main
Labels     meta, tools, author ready, dependencies
Commits    1
 - deps: update nbytes and add update script
Committers 1
 - Yagiz Nizipli <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/53790
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53790
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 09 Jul 2024 19:29:46 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53790#pullrequestreview-2167223610
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-07-10T19:30:28Z: https://ci.nodejs.org/job/node-test-pull-request/60226/
- Querying data for job/node-test-pull-request/60226/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9897439997
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested review from marco-ippolito and mcollina July 11, 2024 19:38
mcollina
mcollina approved these changes Jul 12, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell jasnell added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jul 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 12, 2024
@nodejs-github-bot
nodejs-github-bot merged commit bcdbf88 into main Jul 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator

Landed in bcdbf88
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the update-nbytes branch July 12, 2024 13:58
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig @aduh95
deps: update nbytes and add update script
1ad6649 
PR-URL: #53790
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@aduh95 aduh95 mentioned this pull request Jul 16, 2024
V22.5.0 proposal #53826
Merged
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig @ehsankhfr
deps: update nbytes and add update script
a6974af 
PR-URL: nodejs#53790
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@marco-ippolito marco-ippolito Awaiting requested review from marco-ippolito

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@anonrig @nodejs-github-bot @marco-ippolito @mcollina @jasnell @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.