GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: fix include_dirs of nbytes by zcbenz · Pull Request #53862 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Set correct include dirs for both GYP and GN builds.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zcbenz
deps: fix include_dirs of nbytes
2c8c215
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Jul 16, 2024
anonrig
anonrig approved these changes Jul 16, 2024
View reviewed changes
gengjiawen
gengjiawen approved these changes Jul 16, 2024
View reviewed changes
jasnell
jasnell approved these changes Jul 16, 2024
View reviewed changes
lpinca
lpinca approved these changes Jul 16, 2024
View reviewed changes
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 18, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60408/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60409/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz zcbenz added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 014dad5 into nodejs:main Jul 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

Landed in 014dad5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@zcbenz @ehsankhfr
deps: fix include_dirs of nbytes
8fe92f0 
PR-URL: nodejs#53862
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 28, 2024
@zcbenz @targos
deps: fix include_dirs of nbytes
c114082 
PR-URL: #53862
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
v22.6.0 proposal #54123
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@zcbenz @nodejs-github-bot @jasnell @lpinca @anonrig @gengjiawen @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.