GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: Relocate the status checking code in the onWriteComplete by MCprotein · Pull Request #54032 · nodejs/node

Conversation

@MCprotein

@MCprotein MCprotein commented Jul 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Modified the code to check the status before verifying if the stream is destroyed.

error name refs:

/ / lib/internal/webstreams/adapter.js
  function onWriteComplete(status) {
    if (status < 0) {
      const error = new ErrnoException(status, 'write', this.error);
      this.promise.reject(error);
      this.controller.error(error);
      return;
    }
    this.promise.resolve();
  }

cc. @ronag

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon, HBSPS, rayark1, sungpaks, and injunchoi98 reacted with hooray emoji
All reactions
  • 🎉 5 reactions
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 25, 2024
yoonsooshin
stream: relocate the status checking code in the onwritecomplete
2dddcdd 
relocate the status checking code before verifying if the stream is
destroyed
@MCprotein
MCprotein force-pushed the fix/stream-base-commons-todo branch from 7066edb to 2dddcdd Compare July 25, 2024 06:14
@jakecastelli jakecastelli added the stream Issues and PRs related to Node.js streams. label Jul 27, 2024
@jakecastelli

jakecastelli commented Jul 27, 2024

Copy link
Copy Markdown
Member

cc. @nodejs/streams
MCprotein reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 27, 2024
@benjamingr

benjamingr commented Jul 27, 2024

Copy link
Copy Markdown
Member

I wonder how breaking this is, I'll also trigger a CITGM
MCprotein reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Jul 27, 2024

Copy link
Copy Markdown
Member

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3466/
MCprotein reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 27, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60678/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag approved these changes Jul 27, 2024
View reviewed changes

@ronag ronag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CITGM is ok

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MCprotein reacted with laugh emoji
All reactions
  • 😄 1 reaction
@daeyeon

daeyeon commented Jul 28, 2024

Copy link
Copy Markdown
Member

module test suite failed
Error: The canary is dead:

CITGM currently has an issue that is being investigated under nodejs/citgm#1067.
MCprotein reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60683/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MCprotein

MCprotein commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/60683/

@daeyeon
I think that the citgm is still unstable, should I wait for now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon

daeyeon commented Jul 29, 2024

Copy link
Copy Markdown
Member

Yes. We need to wait until the citgm result is available. Thanks in advance for your patience.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MCprotein

MCprotein commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

Yes. We need to wait until the citgm result is available. Thanks in advance for your patience.

thank you for explaining 😄
daeyeon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Jul 29, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a green CITGM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MCprotein reacted with laugh emoji
All reactions
  • 😄 1 reaction
jasnell
jasnell approved these changes Jul 29, 2024
View reviewed changes
@mcollina

mcollina commented Aug 2, 2024

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3467/
MCprotein reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina mcollina added baking-for-lts PRs whose changes need more time before an LTS backport. commit-queue PRs queued for automated landing through the Commit Queue. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 298dea0 into nodejs:main Sep 2, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in 298dea0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@MCprotein @aduh95
stream: relocate the status checking code in the onwritecomplete
e2307d8 
relocate the status checking code before verifying if the stream is
destroyed

PR-URL: #54032
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
RafaelGSS added a commit that referenced this pull request Sep 16, 2024
@RafaelGSS
2024-09-17, Version 22.9.0 (Current)
9fcecb9 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
@RafaelGSS
2024-09-17, Version 22.9.0 (Current)
85a9935 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
@RafaelGSS
2024-09-17, Version 22.9.0 (Current)
4631be0 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
@RafaelGSS
2024-09-17, Version 22.9.0 (Current)
e49cf7a 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
@aduh95 aduh95 removed the baking-for-lts PRs whose changes need more time before an LTS backport. label Feb 3, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Sep 17, 2026
node:net: emit 'error' once when a buffered write on an adopted fd fails oven-sh/bun#43038
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@ronag ronag ronag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@MCprotein @jakecastelli @benjamingr @nodejs-github-bot @daeyeon @mcollina @jasnell @ronag @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.