GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: explicit about VS 2015 support in readme by phillipj · Pull Request #5406 · nodejs/node

Conversation

@phillipj

@phillipj phillipj commented Feb 24, 2016

Copy link
Copy Markdown
Member

vcbuild.bat already supports both Visual Studio 2013 and 2015. Lets be explicit about it to avoid devs installing an old IDE.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mscdex mscdex added doc Issues and PRs related to Node.js documentation. windows Issues and PRs related to the Windows platform. build Issues and PRs related to Node.js builds or CI infrastructure. labels Feb 24, 2016
@rvagg

rvagg commented Feb 24, 2016

Copy link
Copy Markdown
Member

Is the 2015 thing called "for Windows Desktop"?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg

rvagg commented Feb 24, 2016

Copy link
Copy Markdown
Member

@nodejs/platform-windows any input on clarifying exactly what's supported would be helpful
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@phillipj

phillipj commented Feb 24, 2016

Copy link
Copy Markdown
Member Author

Is the 2015 thing called "for Windows Desktop"?

Yep. https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx#scrum
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orangemocha

orangemocha commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Visual Studio 2013 & 2015, all editions including the Community edition.
Visual Studio Express 2013 for Windows Desktop
Visual Studio Express 2015 for Desktop
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
orangemocha
orangemocha reviewed Feb 25, 2016
View reviewed changes
Comment thread README.md Outdated
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* Visual Studio 2013 for Windows Desktop, or
* Visual Studio Express 2013 for Windows Desktop
* Visual Studio 2013 / 2015 for Windows Desktop, or

@orangemocha orangemocha Feb 25, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full edition doesn't have a "for Windows Desktop" SKU. Only the Visual Studio Express does and it was called "for Windows Desktop" in 2013 and "for Desktop" in 2015.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@phillipj
doc: explicit about VS 2015 support in readme
6cf958e 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.
@phillipj
phillipj force-pushed the readme-vs2015 branch from 4afa7c9 to 6cf958e Compare February 25, 2016 18:06
@phillipj

phillipj commented Feb 25, 2016

Copy link
Copy Markdown
Member Author

@orangemocha just pushed an updated.

Would you agree we can combine the express editions into one line of "for Desktop", rather than having two different lines just to get "for Windows Desktop" for VS Express 2013?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orangemocha

orangemocha commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Seems clear enough to me, but would like to get another +1.

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg

rvagg commented Feb 26, 2016

Copy link
Copy Markdown
Member

lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg

rvagg commented Feb 26, 2016

Copy link
Copy Markdown
Member

landed @ 1d7c370, thanks @phillipj!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg rvagg closed this Feb 26, 2016
rvagg pushed a commit that referenced this pull request Feb 26, 2016
@phillipj @rvagg
doc: explicit about VS 2015 support in readme
1d7c370 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@jasnell jasnell added the lts-watch-v4.x label Feb 26, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@phillipj @rvagg
doc: explicit about VS 2015 support in readme
275aa35 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@phillipj @rvagg
doc: explicit about VS 2015 support in readme
7f2cf9a 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Release proposal: v5.7.1 #5464
Merged
5 tasks done
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@phillipj Myles Borins
doc: explicit about VS 2015 support in readme
14a4b73 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Mar 1, 2016
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@phillipj Myles Borins
doc: explicit about VS 2015 support in readme
394743f 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@phillipj Myles Borins
doc: explicit about VS 2015 support in readme
ae347b5 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@Clemens-git76 Clemens-git76 mentioned this pull request Apr 16, 2024
[Snyk] Upgrade rollup from 2.75.6 to 4.13.0 Clemens-git76/node#4
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@phillipj @rvagg @orangemocha @mscdex @jasnell @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.