GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: fix TypedArray to a global type by 1ilsang · Pull Request #54060 · nodejs/node

Conversation

@1ilsang

@1ilsang 1ilsang commented Jul 26, 2024

Copy link
Copy Markdown
Member
image image
  1. Fixes invalid and unused declarations
  2. Fix TypedArray to a global type

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, MCprotein, and rayark1 reacted with thumbs up emoji daeyeon reacted with hooray emoji
All reactions
  • 👍 3 reactions
  • 🎉 1 reaction
1ilsang added 2 commits July 27, 2024 02:17
@1ilsang
typings: remove unused import
92d6b0a
@1ilsang
typings: fix wrong typo
173cfa4
@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Jul 26, 2024
anonrig
anonrig requested changes Jul 27, 2024
View reviewed changes
Comment thread typings/globals.d.ts Outdated

@anonrig anonrig Jul 27, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce your change to only to the goal of this pull request. It's really hard to review it right now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@1ilsang 1ilsang Jul 27, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig Thank you for your advice

I split it into b6f6827 and f606246 commits.

b6f6827 Main content of this PR, the Global type fix.

f606246 Applied the lint.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rayark1 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
1ilsang added 2 commits July 27, 2024 11:24
@1ilsang
typings: fix TypedArray to a global type
b6f6827
@1ilsang
typings: apply lint
f606246
@1ilsang
1ilsang force-pushed the fix/types branch from 74c8718 to f606246 Compare July 27, 2024 02:27
@1ilsang

1ilsang commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

Split it into three PRs. #54063 #54064 #54065
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1ilsang 1ilsang closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@1ilsang @anonrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.