GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: fix typo on quic onSessionDatagram by 1ilsang · Pull Request #54064 · nodejs/node

Conversation

@1ilsang

@1ilsang 1ilsang commented Jul 27, 2024

Copy link
Copy Markdown
Member
image
  • Fix wrong typo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MCprotein, rayark1, bricss, H4ad, sonsurim, and Kihyun92 reacted with thumbs up emoji
All reactions
  • 👍 6 reactions
@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Jul 27, 2024
This was referenced Jul 27, 2024
typings: fix TypedArray to a global type #54060
Closed
tools: add tsc checker #54069
Closed
H4ad
H4ad approved these changes Jul 27, 2024
View reviewed changes
H4ad
H4ad reviewed Jul 27, 2024
View reviewed changes

@H4ad H4ad left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change your commit message to be more clear about what are you fixing?

Something like: typings: fix typo on quic onSessionDatagram

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1ilsang reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@1ilsang
typings: fix typo on quic onSessionDatagram
d2cf2df
@1ilsang
1ilsang force-pushed the fix/typings-typo branch from bdb2c6b to d2cf2df Compare July 27, 2024 15:34
@1ilsang

1ilsang commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

@H4ad

Hi, d2cf2df Done.

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Jul 27, 2024
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 27, 2024
@deokjinkim deokjinkim changed the title typings: fix wrong typo typings: fix typo on quic onSessionDatagram Jul 28, 2024
deokjinkim
deokjinkim approved these changes Jul 28, 2024
View reviewed changes
jakecastelli
jakecastelli approved these changes Jul 28, 2024
View reviewed changes
lpinca
lpinca approved these changes Jul 28, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 29, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 5210cd8 into nodejs:main Jul 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5210cd8
1ilsang reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 30, 2024
@1ilsang @targos
typings: fix typo on quic onSessionDatagram
0e980d6 
PR-URL: #54064
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
v22.6.0 proposal #54123
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@1ilsang @RafaelGSS
typings: fix typo on quic onSessionDatagram
e8ea49b 
PR-URL: #54064
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H4ad H4ad H4ad approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@1ilsang @nodejs-github-bot @lpinca @anonrig @deokjinkim @H4ad @jakecastelli @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.