GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: fix extensionless typescript in cjs loader by marco-ippolito · Pull Request #54062 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Jul 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Annoying bug that allowed extensionless typescript imports to work in cjs loader.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR and bricss reacted with heart emoji bricss and ChALkeR reacted with rocket emoji
All reactions
  • ❤️ 2 reactions
  • 🚀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 26, 2024
anonrig
anonrig reviewed Jul 27, 2024
View reviewed changes
Comment thread lib/internal/modules/cjs/loader.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito
marco-ippolito force-pushed the feat/fix-annoying-cjs-bug branch 2 times, most recently from 5bbe964 to 75f97ce Compare July 27, 2024 05:28
@ChALkeR ChALkeR mentioned this pull request Jul 27, 2024
module: add --experimental-strip-types #53725
Merged
ChALkeR
ChALkeR reviewed Jul 27, 2024
View reviewed changes
Comment thread lib/internal/modules/cjs/loader.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR
ChALkeR reviewed Jul 27, 2024
View reviewed changes
Comment thread lib/internal/modules/cjs/loader.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR
ChALkeR approved these changes Jul 27, 2024
View reviewed changes

@ChALkeR ChALkeR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the change above for .cts

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ChALkeR

ChALkeR commented Jul 27, 2024

Copy link
Copy Markdown
Member

Also, a test perhaps is missing for the .cts case
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Jul 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ill add a test for cts later today
ChALkeR reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jul 27, 2024
View reviewed changes
anonrig
anonrig approved these changes Jul 27, 2024
View reviewed changes
atlowChemi
atlowChemi approved these changes Jul 28, 2024
View reviewed changes
@marco-ippolito
module: fix extensionless typescript in cjs loader
47589cd
@marco-ippolito
marco-ippolito force-pushed the feat/fix-annoying-cjs-bug branch from 29a83e5 to 47589cd Compare July 28, 2024 07:59
@ChALkeR

ChALkeR commented Jul 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Nice
This looks ready
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60689/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi atlowChemi added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 28, 2024
mcollina
mcollina approved these changes Jul 29, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60714/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60725/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jul 29, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60728/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 29, 2024
@nodejs-github-bot
nodejs-github-bot merged commit cf9a814 into nodejs:main Jul 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

Landed in cf9a814
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 30, 2024
@marco-ippolito @targos
module: fix extensionless typescript in cjs loader
11aef40 
PR-URL: #54062
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
v22.6.0 proposal #54123
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@marco-ippolito @RafaelGSS
module: fix extensionless typescript in cjs loader
ab1f0b4 
PR-URL: #54062
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ChALkeR ChALkeR ChALkeR approved these changes
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@marco-ippolito @nodejs-github-bot @ChALkeR @mcollina @jasnell @benjamingr @anonrig @atlowChemi @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.