GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 12.8 by targos · Pull Request #54077 · nodejs/node

Conversation

@targos

@targos targos commented Jul 28, 2024

Copy link
Copy Markdown
Member

Notable changes:

  • RegExp duplicate named capture groups
  • RegExp modifiers
  • Promise.try

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lin72h, bricss, gengjiawen, avivkeller, and mcollina reacted with hooray emoji bricss, marco-ippolito, H4ad, and lin72h reacted with rocket emoji
All reactions
  • 🎉 5 reactions
  • 🚀 4 reactions
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 28, 2024
@targos targos mentioned this pull request Jul 28, 2024
deps: update V8 to 12.7 #53651
Closed
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 28, 2024
@targos
targos force-pushed the v8-128 branch from f09d022 to 8560272 Compare July 28, 2024 08:22
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

targos commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

Trying Windows again with the new commit: https://ci.nodejs.org/job/node-test-commit-windows-fanned/64381/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the v8-128 branch from 11b6b21 to f6c7e85 Compare July 28, 2024 09:52
@targos targos mentioned this pull request Jul 28, 2024
build: drop experimental support for Windows <10 #54079
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

targos commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

@nodejs/platform-s390 There's a failing V8 test: https://ci.nodejs.org/job/node-test-commit-v8-linux/6098/nodes=rhel8-s390x,v8test=v8test/console

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

We also have a compiler error with ubi81_sharedlibs_openssl111fips_x64:

12:06:12 In file included from ../deps/v8/include/v8-isolate.h:21,
12:06:12                  from ../deps/v8/include/v8-snapshot.h:9,
12:06:12                  from ../deps/v8/include/v8-context.h:15,
12:06:12                  from ../deps/v8/include/v8.h:26,
12:06:12                  from ../src/node_external_reference.h:9,
12:06:12                  from ../src/node_builtins.h:13,
12:06:12                  from ../src/node_builtins.cc:1:
12:06:12 ../deps/v8/include/v8-function-callback.h: In instantiation of 'v8::Isolate* v8::PropertyCallbackInfo<F>::GetIsolate() const [with T = v8::Value]':
12:06:12 ../src/node_builtins.cc:655:62:   required from here
12:06:12 ../deps/v8/include/v8-function-callback.h:695:11: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
12:06:12   695 |   return *reinterpret_cast<Isolate**>(&args_[kIsolateIndex]);
12:06:12       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12:06:12 cc1plus: all warnings being treated as errors
12:06:12 make[2]: *** [libnode.target.mk:439: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode/src/node_builtins.o] Error 1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miladfarca

miladfarca commented Jul 28, 2024

Copy link
Copy Markdown
Contributor

@targos that test is knows to be flaky (on other platforms as well): https://issues.chromium.org/issues/42200980
rerunning the tests should pass it.

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ronag

ronag commented Jul 29, 2024

Copy link
Copy Markdown
Member

I think this also adds support for DisposableStack and AsyncDisposableStack. Maybe notable?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Jul 29, 2024

Copy link
Copy Markdown
Member Author

@ronag it doesn't seem to (DisposableStack is not defined)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ronag

ronag commented Jul 29, 2024

Copy link
Copy Markdown
Member

@ronag it doesn't seem to (DisposableStack is not defined)

Ah, weird. There are references to it in the changes so I thought it was included.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the v8-128 branch from f6c7e85 to 11f49fe Compare August 7, 2024 14:31
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
targos added a commit that referenced this pull request Aug 16, 2024
@LeszekSwirski @targos
build: disable ICF for mksnapshot
9d0748c
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5447267
Co-authored-by: Michaël Zasso <[email protected]>
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos added a commit that referenced this pull request Aug 16, 2024
@targos
test: update v8-stats test for V8 12.6
df9efba
Refs: v8/v8@e30e228
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos added a commit that referenced this pull request Aug 16, 2024
@targos
tools: update V8 gypfiles for 12.6
8044051
Refs: v8/v8@f8fa220
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Aug 16, 2024
@joyeecheung @targos
src: remove dependency on wrapper-descriptor-based CppHeap
0be79f4
As V8 has moved away from wrapper-descriptor-based CppHeap, this
patch:

1. Create the CppHeap without using wrapper descirptors.
2. Deprecates node::SetCppgcReference() in favor of
   v8::Object::Wrap() since the wrapper descriptor is no longer
   relevant. It is still kept as a compatibility layer for addons
   that need to also work on Node.js versions without
   v8::Object::Wrap().

PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Aug 16, 2024
@richardlau @targos
tools: update V8 gypfiles for 12.7
dc352a5
Add/remove abseil files introduced by V8 12.7 update found by:

```
git diff-tree --no-commit-id --name-status 0ec8f7e -r
  | grep '^[AD].*abseil.*'
```

PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos added a commit that referenced this pull request Aug 16, 2024
@targos
tools: update V8 gypfiles for 12.8
64e8646
Refs: v8/v8@06847fb
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Aug 16, 2024
@gahaas @targos
src: stop using deprecated fields of v8::FastApiCallbackOptions
f0134fa
Two fields on the `v8::FastApiCallbackOptions` struct were deprecated
recently: `fallback` and `wasm_memory`. This PR removes uses of these
two fields in node.js.

PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@targos

targos commented Aug 16, 2024

Copy link
Copy Markdown
Member Author

Landed in 7fab6e8...f0134fa

bricss reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos closed this Aug 16, 2024
targos added a commit that referenced this pull request Aug 16, 2024
@targos
deps: patch V8 to avoid duplicated zlib symbol
1a143a7
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos added a commit that referenced this pull request Aug 16, 2024
@targos
deps: always define V8_NODISCARD as no-op
19f043a
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 16, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
2407b09
PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 16, 2024
@targos @nodejs-github-bot
deps: always define V8_NODISCARD as no-op
336460e
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 17, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
8a5a0d0
PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 17, 2024
@targos @nodejs-github-bot
deps: always define V8_NODISCARD as no-op
973621d
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 18, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
4bcac74
PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 18, 2024
@targos @nodejs-github-bot
deps: always define V8_NODISCARD as no-op
c26917c
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 19, 2024
@targos @nodejs-github-bot
deps: patch V8 to avoid duplicated zlib symbol
31dcb4f
PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 19, 2024
@targos @nodejs-github-bot
deps: always define V8_NODISCARD as no-op
f52f1c2
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
doc: reserve ABI 130 for Electron 33 #54383
Merged
targos added a commit that referenced this pull request Aug 24, 2024
@targos
deps: patch V8 to avoid duplicated zlib symbol
26590e7
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@zcbenz

zcbenz commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

It seems that wrapping a cppgc Object with v8::Object has been simplified a lot, would it be possible to wrap a cppgc Object with Node-API now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
@H4ad H4ad mentioned this pull request Nov 10, 2024
Revisit Fast APIs implementations & New implementations nodejs/performance#182
Open
@aduh95 aduh95 mentioned this pull request Jan 22, 2025
libuv assertion on Windows with Node.js 23.x #56645
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jan 31, 2025
deps: update V8 to 13.0 #55014
Closed
@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
2025-10-15, Version 25.0.0 (Current) #59896
Merged
9 tasks done
@edemaine edemaine mentioned this pull request Feb 27, 2026
javascript.regular_expressions: duplicate named groups runtime support mdn/browser-compat-data#29146
Merged
@RafaelGSS RafaelGSS mentioned this pull request Apr 27, 2026
2026-05-05, Version 26.0.0 (Current) #62526
Merged
@don-milsey-miller don-milsey-miller mentioned this pull request Oct 13, 2026
Kiln's Node range admits Windows releases where an RPC launch can crash at exit don-milsey-miller/kiln#218
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronag ronag ronag left review comments
@gengjiawen gengjiawen gengjiawen approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@targos @nodejs-github-bot @miladfarca @ronag @LeszekSwirski @zcbenz @gengjiawen @joyeecheung @richardlau @marco-ippolito @StefanStojanovic @fdoray @gahaas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.