GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: remove outdated comment by targos · Pull Request #54118 · nodejs/node

Conversation

@targos

@targos targos commented Jul 30, 2024

Copy link
Copy Markdown
Member

Refs: #53822

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
module: remove outdated comment
9f4483a 
Refs: nodejs#53822
@nodejs-github-bot

nodejs-github-bot commented Jul 30, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 30, 2024
juanarbol
juanarbol approved these changes Jul 30, 2024
View reviewed changes
aduh95
aduh95 approved these changes Jul 30, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Jul 30, 2024
lpinca
lpinca approved these changes Jul 30, 2024
View reviewed changes
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 31, 2024
@codecov

codecov Bot commented Jul 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (890760b) to head (9f4483a).
Report is 537 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54118      +/-   ##
==========================================
+ Coverage   87.04%   87.07%   +0.02%     
==========================================
  Files         643      643              
  Lines      181589   181588       -1     
  Branches    34883    34888       +5     
==========================================
+ Hits       158072   158110      +38     
+ Misses      16785    16750      -35     
+ Partials     6732     6728       -4
Files with missing lines Coverage Δ
lib/internal/modules/esm/resolve.js 96.45% <ø> (-0.01%) ⬇️

... and 27 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Aug 1, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 1, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54118
✔  Done loading data for nodejs/node/pull/54118
----------------------------------- PR info ------------------------------------
Title      module: remove outdated comment (#54118)
Author     Michaël Zasso <[email protected]> (@targos)
Branch     targos:module-rm-comment -> nodejs:main
Labels     esm, author ready
Commits    1
 - module: remove outdated comment
Committers 1
 - Michaël Zasso <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54118
Refs: https://github.com/nodejs/node/pull/53822
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54118
Refs: https://github.com/nodejs/node/pull/53822
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Jul 2024 10:13:09 GMT
   ✔  Approvals: 4
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207278842
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207294695
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54118#pullrequestreview-2208546573
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54118#pullrequestreview-2211474577
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10196534245
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 00c0644 into nodejs:main Aug 1, 2024
@aduh95

aduh95 commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

Landed in 00c0644
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the module-rm-comment branch August 1, 2024 11:12
targos added a commit that referenced this pull request Aug 14, 2024
@targos
module: remove outdated comment
13cc480 
Refs: #53822
PR-URL: #54118
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
@trivikr trivikr trivikr approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @aduh95 @lpinca @trivikr @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.