GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove unused imports from worker_threads.md by debbs061 · Pull Request #54147 · nodejs/node

Conversation

@debbs061

@debbs061 debbs061 commented Jul 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove unused imports from worker_threads.md.

  • Removed once import from node:events as it was not used in the code.
  • Removed isMainThread import from node:worker_threads as it was not used in the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API. labels Jul 31, 2024
aduh95
aduh95 approved these changes Jul 31, 2024
View reviewed changes
@aduh95 aduh95 changed the title typings: remove unused imports from worker_threads.md doc: remove unused imports from worker_threads.md Jul 31, 2024
deokjinkim
deokjinkim approved these changes Jul 31, 2024
View reviewed changes

@deokjinkim deokjinkim left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debbs061 Thank you for contribution. Could you change subsystem from typings to doc in commit title? You can force push with -f option.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
debbs061 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jul 31, 2024
@github-actions

github-actions Bot commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
aduh95 and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yelim
doc: remove unused imports from worker_threads.md
f2f6dbc
@debbs061
debbs061 force-pushed the unused-import branch from 1fca7ce to f2f6dbc Compare July 31, 2024 15:59
lpinca
lpinca approved these changes Jul 31, 2024
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 31, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 7941b4b into nodejs:main Jul 31, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

Landed in 7941b4b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Aug 14, 2024
@debbs061 @targos
doc: remove unused imports from worker_threads.md
af99ba3 
PR-URL: #54147
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@debbs061 @nodejs-github-bot @lpinca @deokjinkim @aduh95 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.