GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: always disable strict aliasing by targos · Pull Request #54339 · nodejs/node

Conversation

@targos

@targos targos commented Aug 12, 2024

Copy link
Copy Markdown
Member

V8 relies on it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
build: always disable strict aliasing
5d6b4de 
V8 relies on it.
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 12, 2024
@targos

targos commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

Context: #54077 (comment),

node/deps/v8/bazel/defs.bzl

Line 108 in 624db50

"-fno-strict-aliasing",

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Aug 12, 2024
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 12, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61067/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6132/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6132/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6132/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 13, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61073/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61077/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 13, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61087/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2573f74 into nodejs:main Aug 14, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2573f74
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the no-strict-aliasing branch August 14, 2024 18:35
RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
@targos @RafaelGSS
build: always disable strict aliasing
e349dad 
V8 relies on it.

PR-URL: #54339
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
@targos @RafaelGSS
build: always disable strict aliasing
c640a2f 
V8 relies on it.

PR-URL: #54339
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bnoordhuis added a commit to bnoordhuis/mini_racer that referenced this pull request Sep 17, 2024
@bnoordhuis
Disable strict aliasing
29b6a13 
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions)
and, critically, disable strict aliasing, because V8 is not the least
bit strict-aliasing safe.

Upstream turned it off in nodejs/node#54339,
like it always should have been, and I suspect the mismatch may be the
cause of segfaults that show up in production.

Remove -fpermissive, it's not needed and something to discourage.
bnoordhuis added a commit to bnoordhuis/mini_racer that referenced this pull request Sep 17, 2024
@bnoordhuis
Disable strict aliasing
fd8dba1 
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions)
and, critically, disable strict aliasing, because V8 is not the least
bit strict-aliasing safe.

Upstream turned it off in nodejs/node#54339,
like it always should have been, and I suspect the mismatch may be the
cause of segfaults that show up in production.

Remove -fpermissive, it's not needed and something to discourage.
@bnoordhuis bnoordhuis mentioned this pull request Sep 17, 2024
Disable strict aliasing rubyjs/mini_racer#315
Merged
bnoordhuis added a commit to bnoordhuis/mini_racer that referenced this pull request Sep 17, 2024
@bnoordhuis
Disable strict aliasing
54673dd 
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions)
and, critically, disable strict aliasing, because V8 is not the least
bit strict-aliasing safe.

Upstream turned it off in nodejs/node#54339,
like it always should have been, and I suspect the mismatch may be the
cause of segfaults that show up in production.
SamSaffron pushed a commit to rubyjs/mini_racer that referenced this pull request Sep 17, 2024
@bnoordhuis
Disable strict aliasing (#315)
5b9d19e 
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions)
and, critically, disable strict aliasing, because V8 is not the least
bit strict-aliasing safe.

Upstream turned it off in nodejs/node#54339,
like it always should have been, and I suspect the mismatch may be the
cause of segfaults that show up in production.
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
bnoordhuis added a commit to bnoordhuis/mini_racer that referenced this pull request Mar 13, 2025
@bnoordhuis
Disable strict aliasing (rubyjs#315)
fdbe437 
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions)
and, critically, disable strict aliasing, because V8 is not the least
bit strict-aliasing safe.

Upstream turned it off in nodejs/node#54339,
like it always should have been, and I suspect the mismatch may be the
cause of segfaults that show up in production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@targos @nodejs-github-bot @lpinca @anonrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.