GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update amaro to 0.1.6 by nodejs-github-bot · Pull Request #54374 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of amaro to 0.1.6.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
deps: update amaro to 0.1.6
7599df0
@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label Aug 14, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 14, 2024
anonrig
anonrig approved these changes Aug 14, 2024
View reviewed changes
@marco-ippolito

marco-ippolito commented Aug 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I added the commit with the new flag nativeClassProperties.
This flag does not make any behavior change at runtime, and is it tested inside amaro, but allows to emit the same code as TS compiler.
This commit fixes nodejs/typescript#3

Actually I'll do that in a followup PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito
marco-ippolito force-pushed the actions/tools-update-amaro branch from b6cea6b to 7599df0 Compare August 14, 2024 14:21
marco-ippolito
marco-ippolito approved these changes Aug 14, 2024
View reviewed changes
@marco-ippolito marco-ippolito mentioned this pull request Aug 14, 2024
Parameter Properties transform: SWC vs TS (initializer relocation) nodejs/typescript#3
Closed
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 14, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 14, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61106/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Aug 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (c1ec099) to head (7599df0).
Report is 402 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54374      +/-   ##
==========================================
- Coverage   87.08%   87.08%   -0.01%     
==========================================
  Files         648      648              
  Lines      182217   182217              
  Branches    34956    34955       -1     
==========================================
- Hits       158684   158681       -3     
- Misses      16819    16822       +3     
  Partials     6714     6714

see 22 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61124/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65
himself65 approved these changes Aug 15, 2024
View reviewed changes
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61138/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Aug 15, 2024
View reviewed changes
jakecastelli
jakecastelli approved these changes Aug 15, 2024
View reviewed changes
@jakecastelli

jakecastelli commented Aug 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is a bit of situation on the current main (tests which rely on the Fast API would fail) PR 54391 is currently being fast tracked to fix it. Therefore the current CI run (which will rebase on main) would fail consistently.
Once 54391 lands, we can restart the CI for this PR (just for the information).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61147/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61154/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Aug 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@nodejs/build

08:00:27 not ok 3851 pummel/test-fs-readfile-tostring-fail
08:00:27   ---
08:00:27   duration_ms: 224.97000
08:00:27   severity: fail
08:00:27   exitcode: 7
08:00:27   stack: |-
08:00:27     /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/pummel/test-fs-readfile-tostring-fail.js:77
08:00:27       throw err;
08:00:27       ^
08:00:27     
08:00:27     AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOSPC: no space left on device, write
jakecastelli reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61161/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added the strip-types Issues and PRs related to TypeScript type stripping. label Aug 16, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61176/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61220/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 19, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 19, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/54374
✔  Done loading data for nodejs/node/pull/54374
----------------------------------- PR info ------------------------------------
Title      deps: update amaro to 0.1.6 (#54374)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-amaro -> nodejs:main
Labels     lib / src, needs-ci, dependencies, strip-types
Commits    1
 - deps: update amaro to 0.1.6
Committers 1
 - Node.js GitHub Bot <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 14 Aug 2024 14:09:38 GMT
   ✔  Approvals: 5
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238310298
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238350052
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54374#pullrequestreview-2239717919
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240533263
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240538191
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-08-19T08:05:13Z: https://ci.nodejs.org/job/node-test-pull-request/61220/
- Querying data for job/node-test-pull-request/61220/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10452057468
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakecastelli

jakecastelli commented Aug 19, 2024

Copy link
Copy Markdown
Member

✘ Last GitHub CI failed

False report maybe? As I didn't see any failure in Github CI though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Aug 19, 2024

Copy link
Copy Markdown
Member

✘ Last GitHub CI failed

False report maybe? As I didn't see any failure in Github CI though.

yeah looks odd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakecastelli

jakecastelli commented Aug 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I could manually land this if you want, just wanted to double check before I do so. Also would be helpful if the bot can mention in the comment which action was failed 😅
marco-ippolito reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakecastelli pushed a commit that referenced this pull request Aug 19, 2024
@nodejs-github-bot @jakecastelli
deps: update amaro to 0.1.6
d8d3a6b 
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@jakecastelli

jakecastelli commented Aug 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When I use the CLI to land it says:

✘ GitHub CI is still running

instead of Github CI failed

Just for the information.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakecastelli

jakecastelli commented Aug 19, 2024

Copy link
Copy Markdown
Member

Landed in d8d3a6b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakecastelli jakecastelli closed this Aug 19, 2024
@jakecastelli
jakecastelli deleted the actions/tools-update-amaro branch August 19, 2024 12:29
RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.1.6
9df95e2 
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.1.6
b6a3e61 
PR-URL: #54374
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@himself65 himself65 himself65 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. strip-types Issues and PRs related to TypeScript type stripping.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@nodejs-github-bot @marco-ippolito @jakecastelli @anonrig @himself65 @RafaelGSS @targos @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.