GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: properly apply dst offset and src length on fast path by ronag · Pull Request #54391 · nodejs/node

Conversation

@ronag

@ronag ronag commented Aug 15, 2024

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@ronag ronag added the buffer Issues and PRs related to the buffer subsystem. label Aug 15, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 15, 2024
@ronag

ronag commented Aug 15, 2024

Copy link
Copy Markdown
Member Author

@targos @anonrig Is there a way to force our tests to call fast API? Not sure why our existing tests didn't catch this. Nor how to make them catch this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag changed the title buffer: Properly apply offset on fast path buffer: properly apply offset on fast path Aug 15, 2024
@ronag
ronag requested review from anonrig and santigimeno August 15, 2024 06:19
@ronag

This comment was marked as resolved.

Sign in to view
@ronag
ronag force-pushed the fast-string-missing-offset branch from e708a48 to 41c2d89 Compare August 15, 2024 06:20
@ronag
ronag force-pushed the fast-string-missing-offset branch 2 times, most recently from f0ba68b to ea45c6c Compare August 15, 2024 06:25
@ronag
ronag force-pushed the fast-string-missing-offset branch from ea45c6c to 9795353 Compare August 15, 2024 06:26
@ronag
buffer: properly apply dst offset and src length on fast path
bbafef7 
Refs: nodejs#54311 (comment)
PR-URL: nodejs#54391
@ronag
ronag force-pushed the fast-string-missing-offset branch from 9795353 to bbafef7 Compare August 15, 2024 06:28
@ronag ronag changed the title buffer: properly apply offset on fast path buffer: properly apply dst offset and src length on fast path Aug 15, 2024
@ronag ronag added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 15, 2024
@github-actions

github-actions Bot commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ronag. Please 👍 to approve.
jakecastelli, benjamingr, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag requested a review from benjamingr August 15, 2024 06:29
benjamingr
benjamingr approved these changes Aug 15, 2024
View reviewed changes
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61127/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Aug 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (ccf05ef) to head (bbafef7).
Report is 391 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54391      +/-   ##
==========================================
+ Coverage   86.33%   87.08%   +0.74%     
==========================================
  Files         648      648              
  Lines      182290   182310      +20     
  Branches    34812    34985     +173     
==========================================
+ Hits       157385   158757    +1372     
+ Misses      18213    16822    -1391     
- Partials     6692     6731      +39
Files with missing lines Coverage Δ
src/node_buffer.cc 70.64% <100.00%> (+0.03%) ⬆️

... and 98 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag requested a review from jakecastelli August 15, 2024 08:44
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61130/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 15, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61131/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2024
jakecastelli
jakecastelli approved these changes Aug 15, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61134/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61137/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2c14615 into nodejs:main Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2c14615
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau mentioned this pull request Aug 15, 2024
src: move more crypto code to ncrypto #54320
Closed
@avivkeller avivkeller mentioned this pull request Aug 15, 2024
src: use for loop in Dotenv::GetPathFromArgs #54385
Closed
RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
@ronag @RafaelGSS
buffer: properly apply dst offset and src length on fast path
7800893 
Refs: #54311 (comment)
PR-URL: #54391
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
@ronag @RafaelGSS
buffer: properly apply dst offset and src length on fast path
8ba53ae 
Refs: #54311 (comment)
PR-URL: #54391
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes
@santigimeno santigimeno Awaiting requested review from santigimeno

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ronag @nodejs-github-bot @benjamingr @anonrig @jakecastelli @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.