GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use `node:test` in `test-cli-syntax-bad` by avivkeller · Pull Request #54513 · nodejs/node

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 23, 2024

Copy link
Copy Markdown
Member

Now this test will output in the following format (via node:test). This can make debugging easier:

✔ Checking syntax for syntax/bad_syntax.js with -c (31.178327ms)
✔ Checking syntax for syntax/bad_syntax.js with --check (28.406593ms)
✔ Checking syntax for syntax/bad_syntax with -c (28.053855ms)
✔ Checking syntax for syntax/bad_syntax with --check (30.877816ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with -c (33.376369ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with --check (30.007192ms)
✔ Checking syntax for syntax/bad_syntax_shebang with -c (27.548402ms)
✔ Checking syntax for syntax/bad_syntax_shebang with --check (28.443502ms)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@avivkeller
test: use node:test in test-cli-syntax.bad
d2cd2e5
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 23, 2024
@codecov

codecov Bot commented Aug 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (e70bd47) to head (a33839d).
Report is 346 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54513      +/-   ##
==========================================
+ Coverage   87.34%   87.61%   +0.26%     
==========================================
  Files         649      650       +1     
  Lines      182524   182945     +421     
  Branches    35026    35395     +369     
==========================================
+ Hits       159420   160280     +860     
+ Misses      16373    15926     -447     
- Partials     6731     6739       +8

see 124 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Aug 23, 2024
View reviewed changes
@avivkeller avivkeller changed the title test: use node:test in test-cli-syntax.bad test: use node:test in test-cli-syntax-bad Aug 23, 2024
MoLow
MoLow approved these changes Aug 26, 2024
View reviewed changes
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
Comment thread test/sequential/test-cli-syntax-bad.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 27, 2024
View reviewed changes
@avivkeller @jasnell
Update test/sequential/test-cli-syntax-bad.js
f58aa1f 
Co-authored-by: James M Snell <[email protected]>
@cjihrig

cjihrig commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

It looks like there are CI failures.
avivkeller reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller
Update test-cli-syntax-bad.js
a33839d
@avivkeller avivkeller added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Sep 5, 2024
@avivkeller

avivkeller commented Sep 7, 2024

Copy link
Copy Markdown
Member Author

It looks like there are CI failures.

Not anymore 😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 7, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 7, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2024 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62209/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Sep 10, 2024
@avivkeller @jasnell
test: use node:test in test-cli-syntax.bad
5de919b 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Sep 10, 2024

Copy link
Copy Markdown
Member

Landed in 5de919b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Sep 10, 2024
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@avivkeller @aduh95
test: use node:test in test-cli-syntax.bad
722cd2e 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@avivkeller @aduh95
test: use node:test in test-cli-syntax.bad
b96ee30 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@avivkeller @cjihrig @nodejs-github-bot @jasnell @benjamingr @MoLow @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.