GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update amaro to 0.1.8 by nodejs-github-bot · Pull Request #54520 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of amaro to 0.1.8.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
deps: update amaro to 0.1.8
abef85f
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. strip-types Issues and PRs related to TypeScript type stripping. labels Aug 23, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2024
marco-ippolito
marco-ippolito approved these changes Aug 23, 2024
View reviewed changes
@marco-ippolito

marco-ippolito commented Aug 23, 2024

Copy link
Copy Markdown
Member

this update, adds the correct default configuration https://github.com/nodejs/node/pull/54520/files#diff-2eb38b7205bf0f3655deb5fd6ce17d625dce1cfe78d204d16c89a67f35c146e6R492-R499
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito mentioned this pull request Aug 23, 2024
module: use amaro default transform values #54517
Closed
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61370/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2024
@codecov

codecov Bot commented Aug 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (628469c) to head (abef85f).
Report is 318 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54520   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         649      649           
  Lines      182576   182576           
  Branches    35036    35041    +5     
=======================================
+ Hits       159467   159471    +4     
+ Misses      16381    16379    -2     
+ Partials     6728     6726    -2

see 32 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61371/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Aug 23, 2024
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2024
@marco-ippolito marco-ippolito mentioned this pull request Aug 24, 2024
Module detection treats typescript import ... = require as ES module syntax #54514
Closed
ovflowd
ovflowd approved these changes Aug 24, 2024
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Aug 24, 2024
View reviewed changes
@ovflowd

ovflowd commented Aug 24, 2024

Copy link
Copy Markdown
Member

@marco-ippolito do you feel like fast-tracking this PR is necessary?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Aug 24, 2024

Copy link
Copy Markdown
Member

@marco-ippolito do you feel like fast-tracking this PR is necessary?

Its ok Ivr added commit queue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c3fe2d6 into main Aug 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in c3fe2d6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-amaro branch August 25, 2024 10:12
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.1.8
290f6ce 
PR-URL: #54520
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
v22.8.0 proposal #54560
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@ovflowd ovflowd ovflowd approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. strip-types Issues and PRs related to TypeScript type stripping.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @marco-ippolito @ovflowd @benjamingr @RafaelGSS @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.