GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: don't use Fast API for utf8 by ronag · Pull Request #54525 · nodejs/node

Conversation

@ronag

@ronag ronag commented Aug 23, 2024

Copy link
Copy Markdown
Member

Fast API handles invalid UTF differently than the slow API.

Fixes: #54521

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2024
@ronag
ronag force-pushed the fast-utf8 branch from caf876b to c77788f Compare August 23, 2024 14:19
@ronag
buffer: don't use Fast API for utf8
af8a786 
Fast API handles invalid UTF differently than the slow API.

Fixes: nodejs#54521
PR-URL: nodejs#54525
@ronag
ronag force-pushed the fast-utf8 branch from c77788f to af8a786 Compare August 23, 2024 14:20
@ronag

ronag commented Aug 23, 2024

Copy link
Copy Markdown
Member Author

Would be nice if we could have a fast implementation that does the same as WriteUtf8Impl in V8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag requested review from anonrig, benjamingr, santigimeno and targos August 23, 2024 14:28
@ronag ronag mentioned this pull request Aug 23, 2024
buffer: re-enable Fast API for Buffer.write #54526
Merged
@ronag

ronag commented Aug 23, 2024

Copy link
Copy Markdown
Member Author

#54526 Seems like a better option.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag closed this Aug 23, 2024
@codecov

codecov Bot commented Aug 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (9ee3a72) to head (af8a786).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54525      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182561   182559       -2     
  Branches    35041    35040       -1     
==========================================
- Hits       159444   159424      -20     
- Misses      16378    16394      +16     
- Partials     6739     6741       +2
Files Coverage Δ
src/node_buffer.cc 70.07% <100.00%> (-0.58%) ⬇️

... and 17 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno Awaiting requested review from santigimeno
@targos targos Awaiting requested review from targos
@anonrig anonrig Awaiting requested review from anonrig
@benjamingr benjamingr Awaiting requested review from benjamingr

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buffer.from() output breaks after optimizing in nodejs 22.7

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ronag @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.