GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 12.9 by targos · Pull Request #54536 · nodejs/node

Conversation

@targos

@targos targos commented Aug 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Notable changes:

  • Intl.DurationFormat

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, MomenNano, and dnalborczyk reacted with thumbs up emoji bricss, MomenNano, and dnalborczyk reacted with hooray emoji bricss, MomenNano, and dnalborczyk reacted with heart emoji bricss, avivkeller, MomenNano, and dnalborczyk reacted with rocket emoji
All reactions
  • 👍 3 reactions
  • 🎉 3 reactions
  • ❤️ 3 reactions
  • 🚀 4 reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 24, 2024
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 24, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 24, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos
targos force-pushed the v8-129 branch from fd3fe08 to e93ea60 Compare August 24, 2024 11:18
@targos

targos commented Aug 24, 2024

Copy link
Copy Markdown
Member Author

Updated d73e710 to fix the MSVC error.
Opened https://chromium-review.googlesource.com/c/v8/v8/+/5805956 upstream to fix the macOS Clang error.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Aug 24, 2024

Copy link
Copy Markdown
Member Author

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@avivkeller avivkeller added the dependencies PRs that add, update, or configure Node.js dependencies. label Aug 24, 2024
@targos
targos force-pushed the v8-129 branch from e93ea60 to 4bfe870 Compare August 26, 2024 18:05
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 26, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61508/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6156/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6156/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6156/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-osx/60761/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Aug 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-windows-fanned/65162/
https://ci.nodejs.org/job/node-compile-windows-debug/23534/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-osx/60768/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@abmusse

abmusse commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?

Hello @targos I've opened a CL on v8 to resolve that build issue https://chromium-review.googlesource.com/c/v8/v8/+/5789180

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Aug 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried two runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StefanStojanovic

StefanStojanovic commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

@nodejs/platform-windows, somehow Windows debug builds are broken. I tried to runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console

I'll look into it.

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StefanStojanovic

StefanStojanovic commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

So what happens when you run that command (for me it is .\Debug\node.exe deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory=test\addons\hello-world --nodedir="E:\work\node") after compiling in debug mode, is that you get this:

image

Clicking Ignore will get you through it, successfully but in CI we cannot do it. I'm not 100% sure, but I think we had this issue with some of the v12.x updates, Will try to find it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot pushed a commit that referenced this pull request Sep 19, 2024
@targos @nodejs-github-bot
deps: V8: cherry-pick 01a47f3ffff2
1e16779
Original commit message:

    [cfi] Add missing 'typename' in SegmentedTable

    Makes the code more consistent and fixes compilation on older Clang
    versions.

    Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956
    Reviewed-by: Samuel Groß <[email protected]>
    Commit-Queue: Michaël Zasso <[email protected]>
    Reviewed-by: Stephen Röttger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#95809}

Refs: v8/v8@01a47f3
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 19, 2024
@targos @nodejs-github-bot
deps: V8: cherry-pick 97199f686e2f
6e150f9
Original commit message:

    aix: add work around for f16 type

    AIX builds started to fail after this commit https://chromium.googlesource.com/v8/v8.git/+/d057564707d3a5df074b7f49a12a2f1e96638f94.

    Change-Id: I25a5c4ae3b4fe5c27a9fb9e35e2bcd2bbed40351
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789180
    Reviewed-by: Clemens Backes <[email protected]>
    Reviewed-by: Nico Hartmann <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#95952}

Refs: v8/v8@97199f6
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 19, 2024
@abmusse @nodejs-github-bot
tools: add additonal include dirs for V8 on AIX
c8c108f
On AIX, we now include src/wasm/float16.h from within src/utils/utils.h
and src/wasm/float16.h includes additional header files.

PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 19, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
31bfa57
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 19, 2024
@targos
deps: patch V8 to support older Clang versions
8ba6100
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
9d81867
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
9732891
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
32aec93
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
93ddd5c
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 21, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
8bfee76
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 21, 2024
@targos
deps: patch V8 to support older Clang versions
e5567aa
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
6f6b35c
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
11ba45d
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 23, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
c055ca8
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 23, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
7ce7061
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 25, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
dab36e2
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Sep 25, 2024
@targos
deps: patch V8 to support older Clang versions
bad5915
PR-URL: #54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 26, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
f717cff
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 26, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
8e3aa23
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 27, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
2c005ee
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 27, 2024
@targos @nodejs-github-bot
deps: patch V8 to support older Clang versions
0553b5c
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Sep 28, 2024
@StefanStojanovic @targos @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
0d20113
Co-Authored-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
@targos targos mentioned this pull request Dec 6, 2024
tools: remove has_absl_stringify from gyp file #56157
Merged
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jan 31, 2025
deps: update V8 to 13.0 #55014
Closed
@IestynGage IestynGage mentioned this pull request Mar 18, 2025
javascript.builtins.Intl.DurationFormat - Currently works in node version 30.0.0 mdn/browser-compat-data#26249
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@targos @nodejs-github-bot @abmusse @StefanStojanovic @richardlau @gengjiawen @aduh95 @marco-ippolito @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.