GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use valid hostnames by lpinca · Pull Request #54556 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Aug 25, 2024

Copy link
Copy Markdown
Member

Use valid hostnames in
test/sequential/test-net-server-listen-ipv6-link-local.js.

Refs: #54554

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@lpinca
test: use valid hostnames
2d7aee7 
Use valid hostnames in
`test/sequential/test-net-server-listen-ipv6-link-local.js`.

Refs: nodejs#54554
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 25, 2024
@codecov

codecov Bot commented Aug 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (7fea010) to head (2d7aee7).
Report is 326 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54556   +/-   ##
=======================================
  Coverage   87.32%   87.33%           
=======================================
  Files         649      649           
  Lines      182618   182626    +8     
  Branches    35033    35043   +10     
=======================================
+ Hits       159475   159489   +14     
+ Misses      16407    16402    -5     
+ Partials     6736     6735    -1

see 21 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 25, 2024
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 25, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61456/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller

avivkeller commented Aug 25, 2024

Copy link
Copy Markdown
Member

This issue was causing test failures left and right, should this be fast tracked?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller mentioned this pull request Aug 25, 2024
Revert "net: validate host name for server listen" #54554
Closed
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61458/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 25, 2024
@github-actions

github-actions Bot commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.
anonrig and aduh95 reacted with thumbs up emoji avivkeller reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 25, 2024
@anonrig
anonrig requested a review from jasnell August 25, 2024 20:34
@avivkeller avivkeller mentioned this pull request Aug 25, 2024
test: making test-runner-run.mjs ignore colors #54552
Merged
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61460/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Aug 25, 2024
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 1399d4e into nodejs:main Aug 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 1399d4e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca
lpinca deleted the use/valid-hostnames branch August 26, 2024 05:08
@joyeecheung joyeecheung mentioned this pull request Aug 26, 2024
src: use v8::Isolate::GetDefaultLocale() to compute navigator.language #54279
Closed
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@lpinca @RafaelGSS
test: use valid hostnames
66ae9f4 
Use valid hostnames in
`test/sequential/test-net-server-listen-ipv6-link-local.js`.

Refs: #54554
PR-URL: #54556
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
v22.8.0 proposal #54560
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@lpinca @nodejs-github-bot @avivkeller @anonrig @aduh95 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.