GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: throw on invalid encoding in Buffer.from by ronag · Pull Request #54586 · nodejs/node

Conversation

@ronag

@ronag ronag commented Aug 27, 2024

Copy link
Copy Markdown
Member

Refs: #54533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 27, 2024
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Aug 27, 2024
@ronag
ronag force-pushed the from-invalid-encoding branch from 2655e59 to 11fe4ff Compare August 27, 2024 05:36
@ronag
ronag requested a review from mcollina August 27, 2024 05:36
@ronag

ronag commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

@nodejs/buffer
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 27, 2024
View reviewed changes
@codecov

codecov Bot commented Aug 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (c00ea01) to head (9d335ca).
⚠️ Report is 5187 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54586      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182620   182632      +12     
  Branches    35044    35033      -11     
==========================================
- Hits       159484   159481       -3     
- Misses      16397    16419      +22     
+ Partials     6739     6732       -7
Files with missing lines Coverage Δ
lib/buffer.js 96.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Aug 27, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61534/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos reviewed Aug 27, 2024
View reviewed changes
Comment thread lib/buffer.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the from-invalid-encoding branch from 01e19f1 to 3f7fe0c Compare August 27, 2024 13:25
@ronag
buffer: throw on invalid encoding in Buffer.from
9d335ca 
Refs: nodejs#54533
PR-URL: nodejs#54586
@ronag
ronag force-pushed the from-invalid-encoding branch from 3f7fe0c to 9d335ca Compare August 27, 2024 13:26
mcollina
mcollina approved these changes Aug 29, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We should likely fix throughv test. I'll get to it when I can.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShenHongFei ShenHongFei mentioned this pull request Aug 30, 2024
buffer: re-enable Fast API for Buffer.write #54526
Merged
jasnell
jasnell previously approved these changes Aug 31, 2024
View reviewed changes
@jasnell

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62166/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Sep 8, 2024
View reviewed changes
@jasnell
jasnell dismissed their stale review September 8, 2024 17:24

There are relevant non-flaky CI failures that need to be addressed with this PR

@aduh95 aduh95 removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 24, 2024
@aduh95

aduh95 commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

What's the status here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
@mcollina

mcollina commented Nov 8, 2025

Copy link
Copy Markdown
Member

Can you push it again?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@jasnell jasnell jasnell left review comments
+1 more reviewer
@targos targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ronag @nodejs-github-bot @jasnell @aduh95 @mcollina @lpinca @targos @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.