GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test,crypto: update WebCryptoAPI WPT by panva · Pull Request #54593 · nodejs/node

Conversation

@panva

@panva panva commented Aug 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR:

  • updates the WebCryptoAPI WPTs to the latest using git node wpt WebCryptoAPI
  • updates the WPT runner to allow for CJS status files so that more complex expectations can be defined

The CJS status file is necessary for this update since the vectors the WPT update is adding are passing on the Jenkins CI s390x nodes but fail everywhere else, I would love to know why but I didn't dig into it much. Marking the tests as flaky is not accurate, so instead the CJS status file allows to detect os.arch() and change the expectations accordingly.

Refs: #54572
Refs: #54468

cc @redyetidev

Note: I can potentially split the WPT runner update and WebCryptoAPI WPT pull into two separate commits with a rebase label in this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
avivkeller reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@panva
test,crypto: update WebCryptoAPI WPT
e36c683 
Refs: nodejs#54572
Refs: nodejs#54468
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 27, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61562/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added crypto Issues and PRs related to the crypto subsystem. web-standards Issues and PRs related to web-platform APIs and standards compliance. webcrypto Issues and PRs related to the Web Crypto API. labels Aug 27, 2024
jasnell
jasnell approved these changes Aug 27, 2024
View reviewed changes
avivkeller
avivkeller reviewed Aug 27, 2024
View reviewed changes
Comment thread test/wpt/status/WebCryptoAPI.cjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller mentioned this pull request Aug 27, 2024
test: update wpt #54468
Closed
@codecov

codecov Bot commented Aug 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (4ce9864) to head (e36c683).
Report is 2252 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54593   +/-   ##
=======================================
  Coverage   87.33%   87.34%           
=======================================
  Files         649      649           
  Lines      182623   182570   -53     
  Branches    35041    35026   -15     
=======================================
- Hits       159498   159459   -39     
+ Misses      16400    16390   -10     
+ Partials     6725     6721    -4

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 27, 2024
benjamingr
benjamingr approved these changes Aug 27, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61573/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Aug 28, 2024
View reviewed changes
anonrig
anonrig approved these changes Aug 28, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61575/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61576/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61581/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61592/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 28, 2024
View reviewed changes
avivkeller
avivkeller reviewed Aug 28, 2024
View reviewed changes
Comment thread test/common/wpt.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2024
@nodejs-github-bot
nodejs-github-bot merged commit fc02b88 into nodejs:main Aug 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Landed in fc02b88
avivkeller reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
5ee234a 
Refs: #54572
Refs: #54468
PR-URL: #54593
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
v22.8.0 proposal #54560
Merged
@panva
panva deleted the bump-crypto-wpt branch August 31, 2024 10:52
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
panva added a commit to panva/node that referenced this pull request Jun 5, 2025
@panva
test,crypto: update WebCryptoAPI WPT
29ce454 
Refs: nodejs#54572
Refs: nodejs#54468
PR-URL: nodejs#54593
Refs: nodejs#54572
Refs: nodejs#54468
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@panva panva mentioned this pull request Jun 5, 2025
[v20.x backport] various WebCryptoAPI and WPT updates #58589
Closed
@panva panva added backport-open-v20.x and removed dont-land-on-v20.x labels Jun 5, 2025
@panva

panva commented Jun 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

v20.x backport in #58589
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito pushed a commit that referenced this pull request Jun 9, 2025
@panva @marco-ippolito
test,crypto: update WebCryptoAPI WPT
7da8602 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 9, 2025
v20.19.3 proposal #58588
Merged
@panva panva added backported-to-v20.x and removed backport-open-v20.x labels Jun 9, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@panva @marco-ippolito
test,crypto: update WebCryptoAPI WPT
50ab099 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@panva @marco-ippolito
test,crypto: update WebCryptoAPI WPT
8237346 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@panva panva mentioned this pull request Sep 11, 2026
Refactor the WPT test runner to be a python test runner configuration #51854
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller left review comments
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. web-standards Issues and PRs related to web-platform APIs and standards compliance. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@panva @nodejs-github-bot @jasnell @benjamingr @lpinca @anonrig @targos @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.