GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: move more zlib tests to node:test by anonrig · Pull Request #54609 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Aug 28, 2024

Copy link
Copy Markdown
Member

Moving zlib tests to use node:test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig
anonrig requested review from jasnell, mcollina and tniessen August 28, 2024 14:16
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 28, 2024
@codecov

codecov Bot commented Aug 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (4f14eb1) to head (af7fd9a).
Report is 298 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54609      +/-   ##
==========================================
- Coverage   87.34%   87.30%   -0.04%     
==========================================
  Files         649      649              
  Lines      182562   182755     +193     
  Branches    35023    35044      +21     
==========================================
+ Hits       159451   159561     +110     
- Misses      16396    16465      +69     
- Partials     6715     6729      +14

see 45 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added the zlib Issues and PRs related to the zlib module and its compression dependencies. label Aug 28, 2024
@anonrig
anonrig force-pushed the yagiz/zlib-tests-node-test branch from c1b0693 to 7631e70 Compare August 29, 2024 00:36
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 29, 2024
atlowChemi
atlowChemi reviewed Aug 29, 2024
View reviewed changes
Comment thread test/parallel/test-zlib-write-after-close.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi reviewed Aug 29, 2024
View reviewed changes
Comment thread test/parallel/test-zlib-zero-byte.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the yagiz/zlib-tests-node-test branch 3 times, most recently from bdd2e1e to 749198f Compare August 29, 2024 14:07
@anonrig
anonrig requested a review from atlowChemi August 29, 2024 14:08
@anonrig
anonrig force-pushed the yagiz/zlib-tests-node-test branch from 749198f to abf4dcc Compare August 29, 2024 14:09
@anonrig
test: move more zlib tests to node:test
af7fd9a
@anonrig
anonrig force-pushed the yagiz/zlib-tests-node-test branch from abf4dcc to af7fd9a Compare August 29, 2024 14:10
jasnell
jasnell approved these changes Aug 29, 2024
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 29, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61660/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Aug 29, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61668/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61678/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61714/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61743/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61759/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61762/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 1, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 826b753 into nodejs:main Sep 1, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2024

Copy link
Copy Markdown
Collaborator

Landed in 826b753
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig @aduh95
test: move more zlib tests to node:test
67e30de 
PR-URL: #54609
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
@lpinca lpinca mentioned this pull request Jan 22, 2025
improve the structure of the test-event-emitter-num-args file and use the node test runner #56671
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
@mcollina mcollina Awaiting requested review from mcollina
@tniessen tniessen Awaiting requested review from tniessen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@anonrig @nodejs-github-bot @jasnell @atlowChemi @targos @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.