GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: fix sign-compare warning in ncrypto by zcbenz · Pull Request #54624 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

Fix following warning in GN build:

../../node/deps/ncrypto/ncrypto.cc:1197:12: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
 1197 |   if (size < dp.size()) {
      |       ~~~~ ^ ~~~~~~~~~

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zcbenz
deps: fix sign-compare warning in ncrypto
0335dbe
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 29, 2024
anonrig
anonrig approved these changes Aug 29, 2024
View reviewed changes
@anonrig
anonrig requested a review from jasnell August 29, 2024 00:40
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 29, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61624/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 29, 2024
View reviewed changes
atlowChemi
atlowChemi approved these changes Aug 29, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2024 •
edited by jakecastelli
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61682/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz zcbenz added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 31, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d6f5234 into nodejs:main Aug 31, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

Landed in d6f5234
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz
zcbenz deleted the fix-ncrypto-warning branch August 31, 2024 02:11
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@zcbenz @aduh95
deps: fix sign-compare warning in ncrypto
6a32645 
PR-URL: #54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@zcbenz @npaun
deps: fix sign-compare warning in ncrypto
dd8c696 
PR-URL: nodejs/node#54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@zcbenz @nodejs-github-bot @jasnell @anonrig @atlowChemi @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.