GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify expandedSQL behavior by tniessen · Pull Request #54685 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Sep 1, 2024

Copy link
Copy Markdown
Member

I am not sure what exactly the primary use case is for this function given that the Node.js API is not designed for users to manually bind parameters of prepared statements, but this at least clarifies what the function does.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
doc: clarify expandedSQL behavior
020f5a3 
I am not sure what exactly the primary use case is for this function
given that the Node.js API is not designed for users to manually bind
parameters of prepared statements, but this at least clarifies what the
function does.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 1, 2024
targos
targos approved these changes Sep 1, 2024
View reviewed changes
@targos

targos commented Sep 1, 2024

Copy link
Copy Markdown
Member

Maybe the purpose is debugging?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen

tniessen commented Sep 1, 2024

Copy link
Copy Markdown
Member Author

Yeah, maybe users can then copy-paste the SQL query into a different SQLite interface for debugging. I don't think there's any pre-processing besides substituting named parameters for the values.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

Maybe the purpose is debugging?

Yes, that's it. There is value in being able to see what SQL a prepared statement evaluates to.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen

tniessen commented Sep 1, 2024

Copy link
Copy Markdown
Member Author

Ah, I assumed the SQLite developers' intention was to enable this without having to actually execute the statement, hence I was confused by the design here. But that makes sense, thank you!
cjihrig reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added author ready PRs with CI started, the required approvals, and no outstanding review comments. review wanted PRs that need review. labels Sep 1, 2024
@tniessen
tniessen requested a review from cjihrig September 4, 2024 16:04
cjihrig
cjihrig approved these changes Sep 4, 2024
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the text here will be inaccurate once #54721 lands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig

cjihrig commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Specifically just the use of "method"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added commit-queue PRs queued for automated landing through the Commit Queue. and removed review wanted PRs that need review. labels Sep 4, 2024
@tniessen

tniessen commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

Thank you @cjihrig. I will rebase #54721 as necessary. I haven't started CI on that PR yet, and considering the state that our CI is in, I don't expect it to land anytime soon (even though I hope to be proven wrong).
cjihrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6c6a933 into nodejs:main Sep 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6c6a933
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen mentioned this pull request Sep 4, 2024
sqlite: make sourceSQL and expandedSQL string-valued properties #54721
Merged
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@tniessen @aduh95
doc: clarify expandedSQL behavior
62b0007 
I am not sure what exactly the primary use case is for this function
given that the Node.js API is not designed for users to manually bind
parameters of prepared statements, but this at least clarifies what the
function does.

PR-URL: #54685
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tniessen @targos @cjihrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.