GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — zlib: add typings for better dx by anonrig · Pull Request #54699 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Sep 1, 2024

Copy link
Copy Markdown
Member

Adds typescript types for better development experience, and made some small refactorings along the way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
avivkeller, bricss, and octet-stream reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Sep 1, 2024
@anonrig
anonrig requested a review from jasnell September 1, 2024 17:19
LiviaMedeiros
LiviaMedeiros approved these changes Sep 1, 2024
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 1, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 1, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell approved these changes Sep 4, 2024
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig
anonrig force-pushed the yagiz/zlib-add-typings branch from e70548b to 36c76be Compare September 7, 2024 19:05
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62113/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
zlib: add typings for better dx
bda112f
@anonrig
anonrig force-pushed the yagiz/zlib-add-typings branch from 36c76be to bda112f Compare September 10, 2024 15:02
@anonrig
anonrig requested a review from jasnell September 10, 2024 23:51
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62301/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested review from benjamingr, lemire and mcollina September 11, 2024 13:05
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 11, 2024
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 14, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54699
✔  Done loading data for nodejs/node/pull/54699
----------------------------------- PR info ------------------------------------
Title      zlib: add typings for better dx (#54699)
Author     Yagiz Nizipli <[email protected]> (@anonrig)
Branch     anonrig:yagiz/zlib-add-typings -> nodejs:main
Labels     zlib, author ready, needs-ci, typings
Commits    1
 - zlib: add typings for better dx
Committers 1
 - Yagiz Nizipli <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - zlib: add typings for better dx
   ℹ  This PR was created on Sun, 01 Sep 2024 17:15:33 GMT
   ✔  Approvals: 2
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54699#pullrequestreview-2274466297
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54699#pullrequestreview-2281130479
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-11T03:03:50Z: https://ci.nodejs.org/job/node-test-pull-request/62301/
- Querying data for job/node-test-pull-request/62301/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10863187549
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LiviaMedeiros
LiviaMedeiros approved these changes Sep 14, 2024
View reviewed changes
LiviaMedeiros pushed a commit that referenced this pull request Sep 14, 2024
@anonrig @LiviaMedeiros
zlib: add typings for better dx
f468509 
PR-URL: #54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@LiviaMedeiros

LiviaMedeiros commented Sep 14, 2024

Copy link
Copy Markdown
Member

Landed in f468509
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros LiviaMedeiros closed this Sep 14, 2024
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@anonrig @RafaelGSS
zlib: add typings for better dx
2a5aa59 
PR-URL: #54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@anonrig @RafaelGSS
zlib: add typings for better dx
cd88333 
PR-URL: #54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@anonrig @RafaelGSS
zlib: add typings for better dx
8385958 
PR-URL: #54699
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes
@jasnell jasnell Awaiting requested review from jasnell
@lemire lemire Awaiting requested review from lemire
@benjamingr benjamingr Awaiting requested review from benjamingr
@mcollina mcollina Awaiting requested review from mcollina

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@anonrig @nodejs-github-bot @LiviaMedeiros @jasnell @lpinca @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.