GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: respect dereference when copy symlink directory by jazelly · Pull Request #54732 · nodejs/node

Conversation

@jazelly

@jazelly jazelly commented Sep 3, 2024

Copy link
Copy Markdown
Member

Fixes: #54730

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji PhilipTrauner reacted with heart emoji PhilipTrauner reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Sep 3, 2024
@jazelly
jazelly marked this pull request as draft September 3, 2024 13:51
@jazelly @jakecastelli
fs: respect dereference when copy symlink directory
79ef70a 
Co-authored-by: Jake Yuesong Li <[email protected]>
@jazelly
jazelly force-pushed the fix-54730 branch from d3cd38b to 79ef70a Compare September 3, 2024 14:07
@jazelly
jazelly marked this pull request as ready for review September 3, 2024 14:09
anonrig
anonrig approved these changes Sep 3, 2024
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 3, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecov Bot commented Sep 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (298dea0) to head (79ef70a).
Report is 250 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54732   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         650      650           
  Lines      182829   182831    +2     
  Branches    35382    35381    -1     
=======================================
+ Hits       160179   160185    +6     
+ Misses      15931    15925    -6     
- Partials     6719     6721    +2
Files with missing lines Coverage Δ
src/node_file.cc 76.94% <100.00%> (-0.03%) ⬇️

... and 32 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2024 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61922/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested a review from jasnell September 4, 2024 23:33
jasnell
jasnell approved these changes Sep 4, 2024
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit a48852b into nodejs:main Sep 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in a48852b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@jazelly @jakecastelli @aduh95
fs: respect dereference when copy symlink directory
ee89c31 
Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: #54732
Fixes: #54730
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
@jazelly
jazelly deleted the fix-54730 branch November 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cpSync symlink handling regression

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jazelly @nodejs-github-bot @jasnell @anonrig @targos @jakecastelli
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.