GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix Windows async-context-frame memory failure by Qard · Pull Request #54823 · nodejs/node

Conversation

@Qard

@Qard Qard commented Sep 6, 2024

Copy link
Copy Markdown
Member

Possible alternative to #54818 to fix the issue with AsyncContextFrame tests crashing with memory errors on Windows. I suspect we're just spinning up too much stuff and eating all the memory.

cc @nodejs/diagnostics

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Stephen Belanger
test: fix Windows async-context-frame memory failure
925a713
@Qard Qard added test Issues and PRs related to Node.js core tests and test infrastructure. async_local_storage Issues and PRs related to the AsyncLocalStorage API. labels Sep 6, 2024
@Qard
Qard requested a review from jasnell September 6, 2024 21:20
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 6, 2024
@Qard Qard mentioned this pull request Sep 6, 2024
test: split up test-async-context-frame into individual tests #54818
Closed
@Qard Qard added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecov Bot commented Sep 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (ce19715) to head (925a713).
Report is 328 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54823      +/-   ##
==========================================
+ Coverage   87.60%   87.61%   +0.01%     
==========================================
  Files         650      650              
  Lines      182943   182997      +54     
  Branches    35399    35419      +20     
==========================================
+ Hits       160270   160341      +71     
+ Misses      15936    15924      -12     
+ Partials     6737     6732       -5

see 31 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Sep 6, 2024

Copy link
Copy Markdown
Member

I canceled that run to limit what is running on CI right now. I think there are too many concurrent test runs going causing things to fail out. Trying to get things untangled. Will start it again once things appear more stable.
Qard reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2024 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62086/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Sep 7, 2024

Copy link
Copy Markdown
Member

Ok restarted CI. Some of the other tests may still flake out until this is rebased on tip of main but really only interested in the windows run for this specific test. If it looks good then let's rebase this on tip of main and run again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
avivkeller
avivkeller reviewed Sep 7, 2024
View reviewed changes
Comment thread test/parallel/test-async-context-frame.mjs
Comment on lines +45 to +46
// TODO(qard): I think high concurrency causes memory problems on Windows
// concurrency: tests.length

@avivkeller avivkeller Sep 7, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO(qard): I think high concurrency causes memory problems on Windows
// concurrency: tests.length
// TODO(qard): I think high concurrency causes memory problems on Windows.
// concurrency: tests.length

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell

jasnell commented Sep 7, 2024

Copy link
Copy Markdown
Member

CI looks good! Let's go with this.
Qard reacted with hooray emoji Qard reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Sep 7, 2024
View reviewed changes
@Qard

Qard commented Sep 7, 2024

Copy link
Copy Markdown
Member Author

Thanks for managing the CI on that! Sorry for the trouble. 😅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 7, 2024
View reviewed changes
@lpinca

lpinca commented Sep 7, 2024

Copy link
Copy Markdown
Member

Can we also revert 407b61c?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakecastelli
jakecastelli approved these changes Sep 7, 2024
View reviewed changes
@jasnell

jasnell commented Sep 7, 2024

Copy link
Copy Markdown
Member

@lpinca

Can we also revert 407b61c?

I suppose we can but I'd like to give it a few days after this lands to make sure it does, in fact, resolve the flakiness.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Sep 7, 2024
RafaelGSS
RafaelGSS approved these changes Sep 8, 2024
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 8, 2024
@github-actions

github-actions Bot commented Sep 8, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
jakecastelli reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

Requesting fast-track in order to help improve CI stability.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 8, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54823
✔  Done loading data for nodejs/node/pull/54823
----------------------------------- PR info ------------------------------------
Title      test: fix Windows async-context-frame memory failure (#54823)
Author     Stephen Belanger <[email protected]> (@Qard)
Branch     Qard:fix-async-context-frame-window-failure -> nodejs:main
Labels     test, fast-track, author ready, async_local_storage
Commits    1
 - test: fix Windows async-context-frame memory failure
Committers 1
 - Stephen Belanger <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54823
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54823
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 06 Sep 2024 21:20:38 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287302578
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287457244
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287489551
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54823#pullrequestreview-2288434091
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 17 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-07T00:04:28Z: https://ci.nodejs.org/job/node-test-pull-request/62086/
- Querying data for job/node-test-pull-request/62086/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10756651585
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 8, 2024
@jakecastelli jakecastelli added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2024
@nodejs-github-bot
nodejs-github-bot merged commit e1e312d into nodejs:main Sep 8, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2024

Copy link
Copy Markdown
Collaborator

Landed in e1e312d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Qard
Qard deleted the fix-async-context-frame-window-failure branch September 9, 2024 19:17
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
Stephen Belanger @aduh95
test: fix Windows async-context-frame memory failure
8345a60 
PR-URL: #54823
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@joyeecheung joyeecheung mentioned this pull request Sep 18, 2024
test-async-context-frame is flaky #54808
Closed
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
@lpinca lpinca mentioned this pull request Feb 14, 2025
test: fix test-without-async-context-frame.mjs in debug mode #57034
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller left review comments
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_local_storage Issues and PRs related to the AsyncLocalStorage API. author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Qard @nodejs-github-bot @jasnell @lpinca @RafaelGSS @avivkeller @jakecastelli @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.