GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: translate error code properly in cpSync by jazelly · Pull Request #54906 · nodejs/node

Conversation

@jazelly

@jazelly jazelly commented Sep 12, 2024

Copy link
Copy Markdown
Member

UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing.

Refs: #53614 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Sep 12, 2024
@jakecastelli jakecastelli added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 12, 2024
@jazelly
jazelly force-pushed the translate-fs-errors branch from be5dfdd to 4f40f36 Compare September 12, 2024 14:05
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 12, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62355/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Sep 12, 2024
View reviewed changes
@anonrig

anonrig commented Sep 12, 2024

Copy link
Copy Markdown
Member

Nice. Thank you!
jazelly reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 12, 2024
@codecov

codecov Bot commented Sep 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (9db6327) to head (090dce2).
Report is 142 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54906      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files         651      651              
  Lines      183405   183412       +7     
  Branches    35822    35825       +3     
==========================================
- Hits       161499   161497       -2     
- Misses      15159    15160       +1     
- Partials     6747     6755       +8
Files with missing lines Coverage Δ
src/node_file.cc 77.09% <75.00%> (+0.11%) ⬆️

... and 31 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jazelly
jazelly force-pushed the translate-fs-errors branch 2 times, most recently from c94e771 to b49dafb Compare September 13, 2024 06:57
lpinca
lpinca approved these changes Sep 13, 2024
View reviewed changes
Comment thread test/parallel/test-fs-cp.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-fs-cp.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jazelly @jakecastelli
fs: translate error code properly in cpSync
090dce2 
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <[email protected]>
@jazelly
jazelly force-pushed the translate-fs-errors branch from b49dafb to 090dce2 Compare September 13, 2024 08:37
lpinca
lpinca approved these changes Sep 13, 2024
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024 •
edited by jakecastelli
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62388/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Sep 13, 2024
View reviewed changes
@jakecastelli jakecastelli added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 16, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c1afd2c into nodejs:main Sep 16, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in c1afd2c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@jazelly @jakecastelli @RafaelGSS
fs: translate error code properly in cpSync
8997e69 
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@jazelly @jakecastelli @RafaelGSS
fs: translate error code properly in cpSync
beb4925 
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@jazelly @jakecastelli @RafaelGSS
fs: translate error code properly in cpSync
93116dd 
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
@jazelly
jazelly deleted the translate-fs-errors branch November 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jazelly @nodejs-github-bot @anonrig @lpinca @richardlau @targos @jakecastelli
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.