GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove duplicate skip AIX by iwuliz · Pull Request #54917 · nodejs/node

Conversation

@iwuliz

@iwuliz iwuliz commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Skip AIX is already defined on the top, so the { skip: common.isAIX } is duplicated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iwuliz
test: remove duplicate skip AIX
9d1a59d
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 13, 2024
lpinca
lpinca approved these changes Sep 13, 2024
View reviewed changes
@codecov

codecov Bot commented Sep 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e21984b) to head (9d1a59d).
Report is 134 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54917   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files         651      651           
  Lines      183409   183409           
  Branches    35828    35823    -5     
=======================================
+ Hits       161487   161500   +13     
+ Misses      15174    15163   -11     
+ Partials     6748     6746    -2

see 25 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Sep 13, 2024
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62397/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
meixg
meixg approved these changes Sep 13, 2024
View reviewed changes
@lpinca lpinca added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 13, 2024
jakecastelli
jakecastelli approved these changes Sep 14, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6db320a into nodejs:main Sep 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6db320a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@iwuliz @RafaelGSS
test: remove duplicate skip AIX
b429c34 
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@iwuliz
iwuliz deleted the remove-unnecessary-skip-aix branch September 17, 2024 00:13
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@iwuliz @RafaelGSS
test: remove duplicate skip AIX
55d2e75 
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@iwuliz @RafaelGSS
test: remove duplicate skip AIX
23fb03b 
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@meixg meixg meixg approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@iwuliz @nodejs-github-bot @lpinca @richardlau @meixg @jakecastelli @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.