GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test,crypto: update WebCryptoAPI WPT by panva · Pull Request #54925 · nodejs/node

Conversation

@panva

@panva panva commented Sep 13, 2024

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
test,crypto: update WebCryptoAPI WPT
4e86576
@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. webcrypto Issues and PRs related to the Web Crypto API. labels Sep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62412/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added the web-standards Issues and PRs related to web-platform APIs and standards compliance. label Sep 13, 2024
@codecov

codecov Bot commented Sep 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e21984b) to head (4e86576).
Report is 134 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54925   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files         651      651           
  Lines      183409   183442   +33     
  Branches    35828    35826    -2     
=======================================
+ Hits       161487   161524   +37     
+ Misses      15174    15163   -11     
- Partials     6748     6755    +7

see 30 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 14, 2024
View reviewed changes
@lpinca lpinca added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 14, 2024
targos
targos approved these changes Sep 14, 2024
View reviewed changes
mcollina
mcollina approved these changes Sep 14, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 3da465a into nodejs:main Sep 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 3da465a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
e26f6da 
PR-URL: #54925
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
d655d96 
PR-URL: #54925
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
55a12a4 
PR-URL: #54925
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@lpinca lpinca lpinca approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. web-standards Issues and PRs related to web-platform APIs and standards compliance. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@panva @nodejs-github-bot @mcollina @lpinca @targos @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.