GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — os: use const with early return for path by trivikr · Pull Request #54959 · nodejs/node

Conversation

@trivikr

@trivikr trivikr commented Sep 16, 2024

Copy link
Copy Markdown
Member

Refs: #54709 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and amrPOP000 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@trivikr
os: use const with early return for path
4d93f35
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Sep 16, 2024
@codecov

codecov Bot commented Sep 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (53ede87) to head (4d93f35).
Report is 517 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54959      +/-   ##
==========================================
- Coverage   88.07%   88.06%   -0.01%     
==========================================
  Files         652      652              
  Lines      183542   183543       +1     
  Branches    35862    35858       -4     
==========================================
- Hits       161653   161639      -14     
- Misses      15144    15154      +10     
- Partials     6745     6750       +5
Files with missing lines Coverage Δ
lib/os.js 97.35% <100.00%> (+<0.01%) ⬆️

... and 24 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 16, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 16, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes Sep 16, 2024
View reviewed changes
jakecastelli
jakecastelli approved these changes Sep 16, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62477/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 16, 2024
@trivikr trivikr self-assigned this Sep 16, 2024
atlowChemi
atlowChemi approved these changes Sep 16, 2024
View reviewed changes
anonrig
anonrig approved these changes Sep 17, 2024
View reviewed changes
@anonrig

anonrig commented Sep 17, 2024

Copy link
Copy Markdown
Member

You beat me to it. Thank you!
trivikr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 87e7aeb into nodejs:main Sep 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

Landed in 87e7aeb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr
trivikr deleted the tmpdir-use-const-early-return branch September 18, 2024 03:31
targos pushed a commit that referenced this pull request Oct 4, 2024
@trivikr @targos
os: use const with early return for path
3300d59 
PR-URL: #54959
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@trivikr trivikr

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@trivikr @nodejs-github-bot @anonrig @lpinca @jakecastelli @atlowChemi @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.