GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove outdated https import reference by geeksilva97 · Pull Request #55111 · nodejs/node

Conversation

@geeksilva97

@geeksilva97 geeksilva97 commented Sep 25, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs: #53822
Fixes: #55091

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jv-vogler reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. labels Sep 25, 2024
@avivkeller

avivkeller commented Sep 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference
geeksilva97 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geeksilva97
doc: remove outdated https import reference
ab568af
@geeksilva97
geeksilva97 force-pushed the issue-55091 branch from fc8f901 to ab568af Compare September 25, 2024 01:07
@geeksilva97

geeksilva97 commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference

Done
avivkeller reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Sep 25, 2024
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2024
atlowChemi
atlowChemi approved these changes Sep 25, 2024
View reviewed changes
UlisesGascon
UlisesGascon approved these changes Sep 25, 2024
View reviewed changes
lpinca
lpinca approved these changes Sep 25, 2024
View reviewed changes
@geeksilva97 geeksilva97 changed the title Remove old references from doc doc: remove outdated https import reference Sep 27, 2024
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 28, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6d1cd50 into nodejs:main Sep 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6d1cd50
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Oct 4, 2024
@geeksilva97 @targos
doc: remove outdated https import reference
1f7566d 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@geeksilva97 @targos
doc: remove outdated https import reference
bb34990 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@aduh95 aduh95 aduh95 approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@geeksilva97 @nodejs-github-bot @avivkeller @lpinca @UlisesGascon @aduh95 @atlowChemi @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.