GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v22.x backport] doc: update `require(ESM)` history and stability status by aduh95 · Pull Request #55263 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

Backport of #55199

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Oct 4, 2024
@targos
targos force-pushed the v22.x-staging branch from ae9de92 to c988e7e Compare October 4, 2024 17:21
@targos

targos commented Oct 4, 2024

Copy link
Copy Markdown
Member

I removed the problematic commit from staging (#55104 (comment))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Oct 4, 2024
View reviewed changes
@aduh95
aduh95 force-pushed the require-esm-history branch from ee34b20 to 5665a7f Compare October 4, 2024 18:14
lpinca
lpinca approved these changes Oct 5, 2024
View reviewed changes
@aduh95
doc: update require(ESM) history and stability status
5d41b8a 
PR-URL: nodejs#55199
Backport-PR-URL: nodejs#55263
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@aduh95
aduh95 force-pushed the require-esm-history branch from 5665a7f to 5d41b8a Compare October 8, 2024 10:22
@aduh95
aduh95 merged commit 5d41b8a into nodejs:v22.x-staging Oct 8, 2024
@aduh95

aduh95 commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

Landed in 5d41b8a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @targos @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.