GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: reserve 132 for Electron 34 by mlaurencin · Pull Request #55306 · nodejs/node

Conversation

@mlaurencin

@mlaurencin mlaurencin commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

This PR reserves NMV 132 for Electron 34

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mlaurencin
doc: reserve 132 for Electron 34
8833b2f 
This PR reserves NMV 132 for Electron 34
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 7, 2024
richardlau
richardlau approved these changes Oct 7, 2024
View reviewed changes
mlaurencin added a commit to electron/electron that referenced this pull request Oct 7, 2024
@mlaurencin
build: update NMV to 132
3731423 
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
@mlaurencin mlaurencin mentioned this pull request Oct 7, 2024
build: update NMV to 132 electron/electron#44135
Merged
5 tasks
@avivkeller avivkeller added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 7, 2024
jakecastelli
jakecastelli approved these changes Oct 7, 2024
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2024
UlisesGascon
UlisesGascon approved these changes Oct 8, 2024
View reviewed changes
mhdawson
mhdawson approved these changes Oct 8, 2024
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 9, 2024
@nodejs-github-bot
nodejs-github-bot merged commit e79ae1b into nodejs:main Oct 9, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in e79ae1b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VerteDinde pushed a commit to electron/electron that referenced this pull request Oct 9, 2024
@mlaurencin
build: update NMV to 132 (#44135)
d51ef7d 
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 9, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@mlaurencin @yangannyx
build: update NMV to 132 (electron#44135)
a6c3286 
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@mlaurencin @yangannyx
build: update NMV to 132 (electron#44135)
9a83501 
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@mlaurencin @yangannyx
build: update NMV to 132 (electron#44135)
4662d9b 
Node PR: nodejs/node#55306

Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34

Please merge this PR before branching 34-x-y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mlaurencin @nodejs-github-bot @UlisesGascon @richardlau @mhdawson @jakecastelli @aduh95 @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.